Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 1752133002: Search html extension types lazily (Closed)

Created:
4 years, 9 months ago by vsm
Modified:
4 years, 9 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Search html extension types lazily This speeds up compile of helloworld (non html) by 2x, and tools/test.sh by about 30%. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/d62e1606b8e3a8bedcb84e3cb7823936fa428db2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -21 lines) Patch
M lib/src/codegen/js_codegen.dart View 3 chunks +63 lines, -19 lines 0 comments Download
M lib/src/codegen/js_field_storage.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years, 9 months ago (2016-03-01 23:11:39 UTC) #3
Jennifer Messerly
Nice! LGTM
4 years, 9 months ago (2016-03-01 23:19:26 UTC) #4
vsm
4 years, 9 months ago (2016-03-01 23:21:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d62e1606b8e3a8bedcb84e3cb7823936fa428db2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698