Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1613)

Issue 1752103003: OUTPUT element should not match to |:disabled| selector. (Closed)

Created:
4 years, 9 months ago by tkent
Modified:
4 years, 9 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OUTPUT element should not match to |:disabled| selector. Specification: https://html.spec.whatwg.org/multipage/forms.html#the-output-element https://html.spec.whatwg.org/multipage/scripting.html#concept-element-disabled The new behavior matches to Firefox. BUG=591230 TEST=automated Committed: https://crrev.com/324a9f99dc8caa433ee4ea27ee5c9e083c478152 Cr-Commit-Position: refs/heads/master@{#378688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
D third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/selectors/pseudo-classes/disabled-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOutputElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOutputElement.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tkent
Keishi, would you review this please?
4 years, 9 months ago (2016-03-02 03:56:38 UTC) #3
keishi
LGTM
4 years, 9 months ago (2016-03-02 04:00:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752103003/1
4 years, 9 months ago (2016-03-02 04:20:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 04:29:43 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 04:30:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/324a9f99dc8caa433ee4ea27ee5c9e083c478152
Cr-Commit-Position: refs/heads/master@{#378688}

Powered by Google App Engine
This is Rietveld 408576698