Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 17521002: Added a check in Searchbox::OnMostVisitedChanged() to prevent duplicate notifications regarding mos… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/search_tab_helper.cc
diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc
index 25150346fcf29ac0df6440df7526ad476c6c87c4..0f964b8fde59ea364e0e6045a5cc3b9c7f74e9e2 100644
--- a/chrome/browser/ui/search/search_tab_helper.cc
+++ b/chrome/browser/ui/search/search_tab_helper.cc
@@ -91,15 +91,6 @@ void SearchTabHelper::NavigationEntryUpdated() {
UpdateMode(false);
}
-bool SearchTabHelper::UpdateLastKnownMostVisitedItems(
- const std::vector<InstantMostVisitedItem>& items) {
- if (chrome::AreMostVisitedItemsEqual(items, last_known_most_visited_items_))
- return false;
-
- last_known_most_visited_items_ = items;
- return true;
-}
-
void SearchTabHelper::InstantSupportChanged(bool instant_support) {
if (!is_search_enabled_)
return;
@@ -123,7 +114,6 @@ void SearchTabHelper::Observe(
return;
UpdateMode(true);
- last_known_most_visited_items_.clear();
// Already determined the instant support state for this page, do not reset
// the instant support state.

Powered by Google App Engine
This is Rietveld 408576698