Added a check in Searchbox::OnMostVisitedChanged() to prevent duplicate notifications regarding mos…

chrome/renderer/searchbox/searchbox.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/searchbox/searchbox.h"
 
 #include <string>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 10 matching lines @@
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
 #include "third_party/WebKit/public/web/WebView.h"
 #include "ui/base/resource/resource_bundle.h"
 
 namespace {
 
 // Size of the results cache.
 const size_t kMaxInstantAutocompleteResultItemCacheSize = 100;
 
+// Returns true if |items_a| and |items_b| are equal.
+bool AreMostVisitedItemsEqual(
+    const std::vector<InstantMostVisitedItem>& items_a,
+    const std::vector<InstantMostVisitedItem>& items_b) {
+  if (items_a.size() != items_b.size())
+    return false;
+
+  for (size_t i = 0; i < items_b.size(); ++i) {
+    if (items_b[i].url != items_a[i].url ||
+        items_b[i].title != items_a[i].title) {
+      return false;
+    }
+  }
+  return true;
+}
+
 }  // namespace
 
 namespace internal {  // for testing
 
 // Parses |url| and fills in |id| with the InstantRestrictedID obtained from the
 // |url|. |render_view_id| is the ID of the associated RenderView.
 //
 // Valid |url| forms:
 // chrome-search://favicon/<view_id>/<restricted_id>
 // chrome-search://thumb/<view_id>/<restricted_id>
@@ skipping 449 matching lines @@
 }
 
 void SearchBox::SetQuery(const string16& query, bool verbatim) {
   query_ = query;
   verbatim_ = verbatim;
   query_is_restricted_ = false;
 }
 
 void SearchBox::OnMostVisitedChanged(
     const std::vector<InstantMostVisitedItem>& items) {
+  std::vector<InstantMostVisitedItemIDPair> item_id_pairs;
+  GetMostVisitedItems(&item_id_pairs);
+
+  std::vector<InstantMostVisitedItem> last_known_items;
+  for (std::vector<InstantMostVisitedItemIDPair>::const_iterator it =

[samarth, 2013/06/21 20:51:20]

Why bother converting the list? Can't you change AreMostVisitedItemsEqual to
compare the two lists directly?

[kmadhusu, 2013/06/21 21:35:32]

Done.

+           item_id_pairs.begin();
+       it != item_id_pairs.end(); ++it) {
+    last_known_items.push_back(it->second);
+  }
+
+  if (AreMostVisitedItemsEqual(last_known_items, items))
+    return;  // Do not send duplicate onmostvisitedchange events.
+
   most_visited_items_cache_.AddItems(items);
   if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {
     extensions_v8::SearchBoxExtension::DispatchMostVisitedChanged(
         render_view()->GetWebView()->mainFrame());
   }
 }
 
 void SearchBox::GetMostVisitedItems(
     std::vector<InstantMostVisitedItemIDPair>* items) const {
   return most_visited_items_cache_.GetCurrentItems(items);
@@ skipping 10 matching lines @@
   InstantMostVisitedItem item;
   return GetMostVisitedItemWithID(item_id, &item) ? item.url : GURL();
 }
 
 void SearchBox::OnToggleVoiceSearch() {
   if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {
     extensions_v8::SearchBoxExtension::DispatchToggleVoiceSearch(
         render_view()->GetWebView()->mainFrame());
   }
 }