Added a check in Searchbox::OnMostVisitedChanged() to prevent duplicate notifications regarding mos…

chrome/browser/ui/search/search_tab_helper.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/search/search_tab_helper.h"
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search/search.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/url_constants.h"
@@ skipping 73 matching lines @@
   UpdateMode();
 }
 
 void SearchTabHelper::NavigationEntryUpdated() {
   if (!is_search_enabled_)
     return;
 
   UpdateMode();
 }
 
-bool SearchTabHelper::UpdateLastKnownMostVisitedItems(
-    const std::vector<InstantMostVisitedItem>& items) {
-  if (chrome::AreMostVisitedItemsEqual(items, last_known_most_visited_items_))
-    return false;
-
-  last_known_most_visited_items_ = items;
-  return true;
-}
-
 void SearchTabHelper::InstantSupportChanged(bool instant_support) {
   if (!is_search_enabled_)
     return;
 
   model_.SetInstantSupportState(instant_support ? INSTANT_SUPPORT_YES :
                                                   INSTANT_SUPPORT_NO);
 }
 
 bool SearchTabHelper::SupportsInstant() const {
   return model_.instant_support() == INSTANT_SUPPORT_YES;
 }
 
 void SearchTabHelper::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   DCHECK_EQ(content::NOTIFICATION_NAV_ENTRY_COMMITTED, type);
   content::LoadCommittedDetails* load_details =
       content::Details<content::LoadCommittedDetails>(details).ptr();
   if (!load_details->is_main_frame)
     return;
 
   UpdateMode();
-  last_known_most_visited_items_.clear();
 
   // Already determined the instant support state for this page, do not reset
   // the instant support state.
   //
   // When we get a navigation entry committed event, there seem to be two ways
   // to tell whether the navigation was "in-page". Ideally, when
   // LoadCommittedDetails::is_in_page is true, we should have
   // LoadCommittedDetails::type to be NAVIGATION_TYPE_IN_PAGE. Unfortunately,
   // they are different in some cases. To workaround this bug, we are checking
   // (is_in_page || type == NAVIGATION_TYPE_IN_PAGE). Please refer to
@@ skipping 88 matching lines @@
   if (web_contents()->IsActiveEntry(page_id))
     model_.SetTopBarsVisible(true);
 }
 
 void SearchTabHelper::OnSearchBoxHideBars(int page_id) {
   if (web_contents()->IsActiveEntry(page_id)) {
     model_.SetTopBarsVisible(false);
     Send(new ChromeViewMsg_SearchBoxBarsHidden(routing_id()));
   }
 }