sk_sp: Covariant Move Constructor and Move Assignment

sk_sp: Covariant Move Constructor and Move Assignment

Also Covariant Copy Constructor, Copy Assignment,
and comparison operators.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1752093002

Committed: https://skia.googlesource.com/skia/+/cb6cb3841adec77d178c6d6ed006102077fd3c48

[hal.canary, 2016-03-01 21:43:39]

Description was changed from

==========
sk_sp: Covariant Move Constructor and Move Assignment

Also, Covariant comparison operator.
==========

to

==========
sk_sp: Covariant Move Constructor and Move Assignment

Also, Covariant comparison operator.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-03-01 21:44:44]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 21:44:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1752093002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1752093002/1

[commit-bot: I haz the power, 2016-03-01 22:01:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 22:01:14]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2016-03-01 22:45:25]

halcanary@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[hal.canary, 2016-03-01 22:45:25]

ptal

[hal.canary, 2016-03-01 23:18:43]

Description was changed from

==========
sk_sp: Covariant Move Constructor and Move Assignment

Also, Covariant comparison operator.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
sk_sp: Covariant Move Constructor and Move Assignment

Also Covariant Copy Constructor, Copy Assignment,
and comparison operators.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-03-01 23:19:15]

lgtm

https://codereview.chromium.org/1752093002/diff/40001/tests/RefCntTest.cpp
File tests/RefCntTest.cpp (right):

https://codereview.chromium.org/1752093002/diff/40001/tests/RefCntTest.cpp#ne...
tests/RefCntTest.cpp:193: // Test convertable sk_sp assignment.
convertible, fwiw

[hal.canary, 2016-03-01 23:21:09]

https://codereview.chromium.org/1752093002/diff/40001/tests/RefCntTest.cpp
File tests/RefCntTest.cpp (right):

https://codereview.chromium.org/1752093002/diff/40001/tests/RefCntTest.cpp#ne...
tests/RefCntTest.cpp:193: // Test convertable sk_sp assignment.
On 2016/03/01 at 23:19:14, mtklein wrote:
> convertible, fwiw

fixed

[reed1, 2016-03-02 01:32:18]

reed@google.com changed reviewers:
+ bungeman@google.com

[reed1, 2016-03-02 01:32:19]

api lgtm but I'd like bunge to also review

[bungeman-skia, 2016-03-02 14:59:40]

lgtm, with a nit and an observation

https://codereview.chromium.org/1752093002/diff/60001/include/core/SkRefCnt.h
File include/core/SkRefCnt.h (right):

https://codereview.chromium.org/1752093002/diff/60001/include/core/SkRefCnt.h...
include/core/SkRefCnt.h:250: typename =
skstd::enable_if_t<skstd::is_convertible<U, T>::value> >
nit: don't need the extra space between '>'s anymore.

https://codereview.chromium.org/1752093002/diff/60001/include/core/SkRefCnt.h...
include/core/SkRefCnt.h:273: SkSafeUnref(fPtr);
I know it's not directly related to this CL, but this should probably be
SkSafeSetNull, or at least set fPtr to nullptr in debug so that we fail a bit
earlier in error cases.

[hal.canary, 2016-03-02 15:07:26]

https://codereview.chromium.org/1752093002/diff/60001/include/core/SkRefCnt.h
File include/core/SkRefCnt.h (right):

https://codereview.chromium.org/1752093002/diff/60001/include/core/SkRefCnt.h...
include/core/SkRefCnt.h:250: typename =
skstd::enable_if_t<skstd::is_convertible<U, T>::value> >
On 2016/03/02 at 14:59:40, bungeman1 wrote:
> nit: don't need the extra space between '>'s anymore.

done

https://codereview.chromium.org/1752093002/diff/60001/include/core/SkRefCnt.h...
include/core/SkRefCnt.h:273: SkSafeUnref(fPtr);
On 2016/03/02 at 14:59:39, bungeman1 wrote:
> I know it's not directly related to this CL, but this should probably be
SkSafeSetNull, or at least set fPtr to nullptr in debug so that we fail a bit
earlier in error cases.

Let's do that in Debug in SkSafeUnref in a separate CL.

[hal.canary, 2016-03-02 15:07:31]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2016-03-02 15:07:32]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com,
bungeman@google.com, reed@google.com
Link to the patchset: https://codereview.chromium.org/1752093002/#ps80001
(title: "no more space between > >")

[commit-bot: I haz the power, 2016-03-02 15:07:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1752093002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1752093002/80001

[commit-bot: I haz the power, 2016-03-02 16:11:28]

Description was changed from

==========
sk_sp: Covariant Move Constructor and Move Assignment

Also Covariant Copy Constructor, Copy Assignment,
and comparison operators.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
sk_sp: Covariant Move Constructor and Move Assignment

Also Covariant Copy Constructor, Copy Assignment,
and comparison operators.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/cb6cb3841adec77d178c6d6ed006102077fd3c48
==========

[commit-bot: I haz the power, 2016-03-02 16:11:29]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/cb6cb3841adec77d178c6d6ed006102077fd3c48