Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.h

Issue 1752043002: Merged FrameView and LayoutBox scrolling in EventHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@invertScrollCustomizationPath
Patch Set: Added comment on LayoutView::scroll Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/EventHandler.h
diff --git a/third_party/WebKit/Source/core/input/EventHandler.h b/third_party/WebKit/Source/core/input/EventHandler.h
index d29d956d7f26d35f95e06cd26356f7baf826a9f6..762131d97a2fb53b6a803187154da3344bae6aee 100644
--- a/third_party/WebKit/Source/core/input/EventHandler.h
+++ b/third_party/WebKit/Source/core/input/EventHandler.h
@@ -266,17 +266,20 @@ private:
ScrollableArea* associatedScrollableArea(const PaintLayer*) const;
// Performs a chaining scroll, within a *single* frame, starting from a
- // given node and optionally stopping on a given node. Does *not* attempt
- // to scroll the layout view.
+ // given node and optionally stopping on a given node.
// granularity - The units that the scroll delta parameter is in.
// delta - The delta to scroll by, in the units of the granularity param
// (e.g. pixels, lines, pages, etc.). These are in a physical
// direction. i.e. Positive is down and right.
// startNode - The node to start the scroll chaining from.
- // stopNode - On input, if provided and non-null, the node at which we
- // should stop chaining. On output, if provided and a node was
- // scrolled, stopNode will point to that node.
- ScrollResult physicalScroll(ScrollGranularity, const FloatSize& delta, Node* startNode, Node** stopNode = nullptr);
+ // stopNode - On input, if non-null, the node at which we should stop
+ // chaining. On output, if provided and a node was scrolled,
+ // stopNode will point to that node.
+ // consumed - [OUT] Whether the scroll was consumed. This is different than
+ // ScrollResult.didScroll since we might not have scrolled but
+ // have reached the stopNode and thus don't want to continue
+ // chaining the scroll.
+ ScrollResult physicalScroll(ScrollGranularity, const FloatSize& delta, Node* startNode, Node** stopNode, bool& consumed);
tdresser 2016/03/03 15:28:27 Output parameters must be pointers, according to t
bokan 2016/03/03 19:53:26 Done.
// Performs a chaining logical scroll, within a *single* frame, starting
// from either a provided starting node or a default based on the focused or
« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalFrame.cpp ('k') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698