third_party/WebKit/Source/web/tests/TopControlsTest.cpp - Issue 1752043002: Merged FrameView and LayoutBox scrolling in EventHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/TopControlsTest.cpp

Issue 1752043002: Merged FrameView and LayoutBox scrolling in EventHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@invertScrollCustomizationPath

Patch Set: Fixes for layout tests breaks Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-div.html ('K') | « third_party/WebKit/Source/core/layout/LayoutView.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/TopControlsTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/TopControlsTest.cpp b/third_party/WebKit/Source/web/tests/TopControlsTest.cpp

index cdfd26de18e18319fefad3bcc99544a9c59fdb69..f8b02f281840fe275bd6177db8f264fb3e1d2f62 100644

--- a/third_party/WebKit/Source/web/tests/TopControlsTest.cpp

+++ b/third_party/WebKit/Source/web/tests/TopControlsTest.cpp

@@ -167,7 +167,7 @@ TEST_F(TopControlsTest, MAYBE(HideOnScrollDown))

EXPECT_FLOAT_EQ(25.f, webView->topControls().contentOffset());

EXPECT_POINT_EQ(IntPoint(0, 0), frame()->view()->scrollPosition());

- // Top controls should consume 30px and become hidden. Excess scroll should be consumed by the page.

+ // Top controls should consume 25px and become hidden. Excess scroll should be consumed by the page.

webView->handleInputEvent(generateEvent(WebInputEvent::GestureScrollUpdate, 0, -40.f));

EXPECT_FLOAT_EQ(0.f, webView->topControls().contentOffset());

EXPECT_POINT_EQ(IntPoint(0, 15), frame()->view()->scrollPosition());