Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: tools/gn/toolchain.cc

Issue 1752033002: Add "create_bundle" target in order to support bundle with gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-bundle-data
Patch Set: Add unit tests, address comments, update docs and format with clang-format Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/toolchain.h ('k') | tools/gn/variables.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/toolchain.cc
diff --git a/tools/gn/toolchain.cc b/tools/gn/toolchain.cc
index ee8e7e869ac68c077e1dedce95dd4043ccd869a7..280fb12d6f2a734e225897a15605f86e4c4c8265 100644
--- a/tools/gn/toolchain.cc
+++ b/tools/gn/toolchain.cc
@@ -24,6 +24,8 @@ const char* Toolchain::kToolSolinkModule = "solink_module";
const char* Toolchain::kToolLink = "link";
const char* Toolchain::kToolStamp = "stamp";
const char* Toolchain::kToolCopy = "copy";
+const char* Toolchain::kToolCopyBundleData = "copy_bundle_data";
+const char* Toolchain::kToolCompileXCAssets = "compile_xcassets";
Toolchain::Toolchain(const Settings* settings, const Label& label)
: Item(settings, label),
@@ -56,6 +58,8 @@ Toolchain::ToolType Toolchain::ToolNameToType(const base::StringPiece& str) {
if (str == kToolLink) return TYPE_LINK;
if (str == kToolStamp) return TYPE_STAMP;
if (str == kToolCopy) return TYPE_COPY;
+ if (str == kToolCopyBundleData) return TYPE_COPY_BUNDLE_DATA;
+ if (str == kToolCompileXCAssets) return TYPE_COMPILE_XCASSETS;
return TYPE_NONE;
}
@@ -74,6 +78,8 @@ std::string Toolchain::ToolTypeToName(ToolType type) {
case TYPE_LINK: return kToolLink;
case TYPE_STAMP: return kToolStamp;
case TYPE_COPY: return kToolCopy;
+ case TYPE_COPY_BUNDLE_DATA: return kToolCopyBundleData;
+ case TYPE_COMPILE_XCASSETS: return kToolCompileXCAssets;
default:
NOTREACHED();
return std::string();
@@ -154,6 +160,7 @@ Toolchain::ToolType Toolchain::GetToolTypeForTargetFinalOutput(
case Target::ACTION:
case Target::ACTION_FOREACH:
case Target::BUNDLE_DATA:
+ case Target::CREATE_BUNDLE:
case Target::COPY_FILES:
return TYPE_STAMP;
default:
« no previous file with comments | « tools/gn/toolchain.h ('k') | tools/gn/variables.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698