Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Unified Diff: tools/gn/ninja_create_bundle_target_writer_unittest.cc

Issue 1752033002: Add "create_bundle" target in order to support bundle with gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-bundle-data
Patch Set: Add unit tests, address comments, update docs and format with clang-format Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_create_bundle_target_writer.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_create_bundle_target_writer_unittest.cc
diff --git a/tools/gn/ninja_create_bundle_target_writer_unittest.cc b/tools/gn/ninja_create_bundle_target_writer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..88e6fbab34dd6336befb97e5d0df4f4497bf081b
--- /dev/null
+++ b/tools/gn/ninja_create_bundle_target_writer_unittest.cc
@@ -0,0 +1,173 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "tools/gn/ninja_create_bundle_target_writer.h"
+
+#include <algorithm>
+#include <sstream>
+
+#include "testing/gtest/include/gtest/gtest.h"
+#include "tools/gn/target.h"
+#include "tools/gn/test_with_scope.h"
+
+namespace {
+
+void SetupBundleDataDir(BundleData* bundle_data, const std::string& root_dir) {
+ bundle_data->root_dir().assign(root_dir + "/bar.bundle");
+ bundle_data->resources_dir().assign(bundle_data->root_dir() + "/Resources");
+ bundle_data->executable_dir().assign(bundle_data->root_dir() + "/Executable");
+ bundle_data->plugins_dir().assign(bundle_data->root_dir() + "/PlugIns");
+}
+
+} // namespace
+
+// Tests multiple files with an output pattern.
+TEST(NinjaCreateBundleTargetWriter, Run) {
+ TestWithScope setup;
+ Err err;
+
+ setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
+ Target target(setup.settings(), Label(SourceDir("//baz/"), "bar"));
+ target.set_output_type(Target::CREATE_BUNDLE);
+
+ SetupBundleDataDir(&target.bundle_data(), "//out/Debug");
+
+ std::vector<SourceFile> sources;
+ sources.push_back(SourceFile("//foo/input1.txt"));
+ sources.push_back(SourceFile("//foo/input2.txt"));
+ target.bundle_data().file_rules().push_back(BundleFileRule(
+ sources, SubstitutionPattern::MakeForTest(
+ "{{bundle_resources_dir}}/{{source_file_part}}")));
+
+ target.SetToolchain(setup.toolchain());
+ ASSERT_TRUE(target.OnResolved(&err));
+
+ std::ostringstream out;
+ NinjaCreateBundleTargetWriter writer(&target, out);
+ writer.Run();
+
+ const char expected[] =
+ "build bar.bundle/Resources/input1.txt: copy_bundle_data "
+ "../../foo/input1.txt\n"
+ "build bar.bundle/Resources/input2.txt: copy_bundle_data "
+ "../../foo/input2.txt\n"
+ "\n"
+ "build obj/baz/bar.stamp: stamp "
+ "bar.bundle/Resources/input1.txt "
+ "bar.bundle/Resources/input2.txt\n";
+ std::string out_str = out.str();
+ EXPECT_EQ(expected, out_str);
+}
+
+// Tests multiple files from asset catalog.
+TEST(NinjaCreateBundleTargetWriter, AssetCatalog) {
+ TestWithScope setup;
+ Err err;
+
+ setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
+ Target target(setup.settings(), Label(SourceDir("//baz/"), "bar"));
+ target.set_output_type(Target::CREATE_BUNDLE);
+
+ SetupBundleDataDir(&target.bundle_data(), "//out/Debug");
+
+ std::vector<SourceFile>& asset_catalog_sources =
+ target.bundle_data().asset_catalog_sources();
+ asset_catalog_sources.push_back(
+ SourceFile("//foo/Foo.xcassets/foo.imageset/Contents.json"));
+ asset_catalog_sources.push_back(
+ SourceFile("//foo/Foo.xcassets/foo.imageset/FooIcon-29.png"));
+ asset_catalog_sources.push_back(
+ SourceFile("//foo/Foo.xcassets/foo.imageset/FooIcon-29@2x.png"));
+ asset_catalog_sources.push_back(
+ SourceFile("//foo/Foo.xcassets/foo.imageset/FooIcon-29@3x.png"));
+
+ target.SetToolchain(setup.toolchain());
+ ASSERT_TRUE(target.OnResolved(&err));
+
+ std::ostringstream out;
+ NinjaCreateBundleTargetWriter writer(&target, out);
+ writer.Run();
+
+ const char expected[] =
+ "build bar.bundle/Resources/Assets.car: compile_xcassets "
+ "../../foo/Foo.xcassets | "
+ "../../foo/Foo.xcassets/foo.imageset/Contents.json "
+ "../../foo/Foo.xcassets/foo.imageset/FooIcon-29.png "
+ "../../foo/Foo.xcassets/foo.imageset/FooIcon-29@2x.png "
+ "../../foo/Foo.xcassets/foo.imageset/FooIcon-29@3x.png\n"
+ "\n"
+ "build obj/baz/bar.stamp: stamp bar.bundle/Resources/Assets.car\n";
+ std::string out_str = out.str();
+ EXPECT_EQ(expected, out_str);
+}
+
+// Tests complex target with multiple bundle_data sources, including
+// some asset catalog.
+TEST(NinjaCreateBundleTargetWriter, OrderOnlyDeps) {
+ TestWithScope setup;
+ Err err;
+
+ setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
+ Target target(setup.settings(), Label(SourceDir("//baz/"), "bar"));
+ target.set_output_type(Target::CREATE_BUNDLE);
+
+ SetupBundleDataDir(&target.bundle_data(), "//out/Debug");
+
+ std::vector<SourceFile> sources1;
+ sources1.push_back(SourceFile("//foo/input1.txt"));
+ sources1.push_back(SourceFile("//foo/input2.txt"));
+ target.bundle_data().file_rules().push_back(BundleFileRule(
+ sources1, SubstitutionPattern::MakeForTest(
+ "{{bundle_resources_dir}}/{{source_file_part}}")));
+
+ std::vector<SourceFile> sources2;
+ sources2.push_back(SourceFile("//qux/Info.plist"));
+ target.bundle_data().file_rules().push_back(BundleFileRule(
+ sources2,
+ SubstitutionPattern::MakeForTest("{{bundle_root_dir}}/Info.plist")));
+
+ std::vector<SourceFile> empty_source;
+ target.bundle_data().file_rules().push_back(BundleFileRule(
+ empty_source, SubstitutionPattern::MakeForTest(
+ "{{bundle_plugins_dir}}/{{source_file_part}}")));
+
+ std::vector<SourceFile>& asset_catalog_sources =
+ target.bundle_data().asset_catalog_sources();
+ asset_catalog_sources.push_back(
+ SourceFile("//foo/Foo.xcassets/foo.imageset/Contents.json"));
+ asset_catalog_sources.push_back(
+ SourceFile("//foo/Foo.xcassets/foo.imageset/FooIcon-29.png"));
+ asset_catalog_sources.push_back(
+ SourceFile("//foo/Foo.xcassets/foo.imageset/FooIcon-29@2x.png"));
+ asset_catalog_sources.push_back(
+ SourceFile("//foo/Foo.xcassets/foo.imageset/FooIcon-29@3x.png"));
+
+ target.SetToolchain(setup.toolchain());
+ ASSERT_TRUE(target.OnResolved(&err));
+
+ std::ostringstream out;
+ NinjaCreateBundleTargetWriter writer(&target, out);
+ writer.Run();
+
+ const char expected[] =
+ "build bar.bundle/Resources/input1.txt: copy_bundle_data "
+ "../../foo/input1.txt\n"
+ "build bar.bundle/Resources/input2.txt: copy_bundle_data "
+ "../../foo/input2.txt\n"
+ "build bar.bundle/Info.plist: copy_bundle_data ../../qux/Info.plist\n"
+ "build bar.bundle/Resources/Assets.car: compile_xcassets "
+ "../../foo/Foo.xcassets | "
+ "../../foo/Foo.xcassets/foo.imageset/Contents.json "
+ "../../foo/Foo.xcassets/foo.imageset/FooIcon-29.png "
+ "../../foo/Foo.xcassets/foo.imageset/FooIcon-29@2x.png "
+ "../../foo/Foo.xcassets/foo.imageset/FooIcon-29@3x.png\n"
+ "\n"
+ "build obj/baz/bar.stamp: stamp "
+ "bar.bundle/Resources/input1.txt "
+ "bar.bundle/Resources/input2.txt "
+ "bar.bundle/Info.plist "
+ "bar.bundle/Resources/Assets.car\n";
+ std::string out_str = out.str();
+ EXPECT_EQ(expected, out_str);
+}
« no previous file with comments | « tools/gn/ninja_create_bundle_target_writer.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698