Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: tools/gn/ninja_target_writer.cc

Issue 1752033002: Add "create_bundle" target in order to support bundle with gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-bundle-data
Patch Set: Add unit tests, address comments, update docs and format with clang-format Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/gn/ninja_create_bundle_target_writer_unittest.cc ('k') | tools/gn/substitution_type.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/gn/ninja_target_writer.h" 5 #include "tools/gn/ninja_target_writer.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
11 #include "tools/gn/err.h" 11 #include "tools/gn/err.h"
12 #include "tools/gn/escape.h" 12 #include "tools/gn/escape.h"
13 #include "tools/gn/filesystem_utils.h" 13 #include "tools/gn/filesystem_utils.h"
14 #include "tools/gn/ninja_action_target_writer.h" 14 #include "tools/gn/ninja_action_target_writer.h"
15 #include "tools/gn/ninja_binary_target_writer.h" 15 #include "tools/gn/ninja_binary_target_writer.h"
16 #include "tools/gn/ninja_bundle_data_target_writer.h" 16 #include "tools/gn/ninja_bundle_data_target_writer.h"
17 #include "tools/gn/ninja_copy_target_writer.h" 17 #include "tools/gn/ninja_copy_target_writer.h"
18 #include "tools/gn/ninja_create_bundle_target_writer.h"
18 #include "tools/gn/ninja_group_target_writer.h" 19 #include "tools/gn/ninja_group_target_writer.h"
19 #include "tools/gn/ninja_utils.h" 20 #include "tools/gn/ninja_utils.h"
20 #include "tools/gn/output_file.h" 21 #include "tools/gn/output_file.h"
21 #include "tools/gn/scheduler.h" 22 #include "tools/gn/scheduler.h"
22 #include "tools/gn/string_utils.h" 23 #include "tools/gn/string_utils.h"
23 #include "tools/gn/substitution_writer.h" 24 #include "tools/gn/substitution_writer.h"
24 #include "tools/gn/target.h" 25 #include "tools/gn/target.h"
25 #include "tools/gn/trace.h" 26 #include "tools/gn/trace.h"
26 27
27 NinjaTargetWriter::NinjaTargetWriter(const Target* target, 28 NinjaTargetWriter::NinjaTargetWriter(const Target* target,
(...skipping 26 matching lines...) Expand all
54 base::CreateDirectory(ninja_file.DirName()); 55 base::CreateDirectory(ninja_file.DirName());
55 56
56 // It's ridiculously faster to write to a string and then write that to 57 // It's ridiculously faster to write to a string and then write that to
57 // disk in one operation than to use an fstream here. 58 // disk in one operation than to use an fstream here.
58 std::stringstream file; 59 std::stringstream file;
59 60
60 // Call out to the correct sub-type of writer. 61 // Call out to the correct sub-type of writer.
61 if (target->output_type() == Target::BUNDLE_DATA) { 62 if (target->output_type() == Target::BUNDLE_DATA) {
62 NinjaBundleDataTargetWriter writer(target, file); 63 NinjaBundleDataTargetWriter writer(target, file);
63 writer.Run(); 64 writer.Run();
65 } else if (target->output_type() == Target::CREATE_BUNDLE) {
66 NinjaCreateBundleTargetWriter writer(target, file);
67 writer.Run();
64 } else if (target->output_type() == Target::COPY_FILES) { 68 } else if (target->output_type() == Target::COPY_FILES) {
65 NinjaCopyTargetWriter writer(target, file); 69 NinjaCopyTargetWriter writer(target, file);
66 writer.Run(); 70 writer.Run();
67 } else if (target->output_type() == Target::ACTION || 71 } else if (target->output_type() == Target::ACTION ||
68 target->output_type() == Target::ACTION_FOREACH) { 72 target->output_type() == Target::ACTION_FOREACH) {
69 NinjaActionTargetWriter writer(target, file); 73 NinjaActionTargetWriter writer(target, file);
70 writer.Run(); 74 writer.Run();
71 } else if (target->output_type() == Target::GROUP) { 75 } else if (target->output_type() == Target::GROUP) {
72 NinjaGroupTargetWriter writer(target, file); 76 NinjaGroupTargetWriter writer(target, file);
73 writer.Run(); 77 writer.Run();
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 << GetNinjaRulePrefixForToolchain(settings_) 280 << GetNinjaRulePrefixForToolchain(settings_)
277 << Toolchain::ToolTypeToName(Toolchain::TYPE_STAMP); 281 << Toolchain::ToolTypeToName(Toolchain::TYPE_STAMP);
278 path_output_.WriteFiles(out_, files); 282 path_output_.WriteFiles(out_, files);
279 283
280 if (!order_only_deps.empty()) { 284 if (!order_only_deps.empty()) {
281 out_ << " ||"; 285 out_ << " ||";
282 path_output_.WriteFiles(out_, order_only_deps); 286 path_output_.WriteFiles(out_, order_only_deps);
283 } 287 }
284 out_ << std::endl; 288 out_ << std::endl;
285 } 289 }
OLDNEW
« no previous file with comments | « tools/gn/ninja_create_bundle_target_writer_unittest.cc ('k') | tools/gn/substitution_type.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698