Issue 1752023002: Clear static ElementFactory state at the start of all resolver tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1752023002: Clear static ElementFactory state at the start of all resolver tests. (Closed)

Created:
4 years, 9 months ago by Paul Berry

Modified:
4 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Clear static ElementFactory state at the start of all resolver tests. This prevents the ElementFactory's ClassElement for `Object` (which it stores statically) from getting accidentally shared between separate unit tests in a single test run, which could cause state to leak between the tests. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/5772408ed0900a9972cd52a566e63b336bd51449

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	pkg/analyzer/lib/src/generated/testing/element_factory.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
	M	pkg/analyzer/test/generated/resolver_test.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years, 9 months ago (2016-03-01 19:26:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5772408ed0900a9972cd52a566e63b336bd51449 (presubmit successful).