Disable retroactive begin frame for synchronous compositor

Disable retroactive begin frame for synchronous compositor

Android WebView can only draw when the system asks us to draw. So it is
incorrect to perform retroactive begin frames.

BUG=
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207723

[boliu, 2013-06-20 22:25:57]

Hey Brian, android webview can only draw when system asks us to draw, so we
really don't want retroactive begin frames (unless it also happens to be
synchronous inside the first begin frame...)

So for now, disable this in synchronous compositor with a capability.

FYI for now, test coming soon...

[boliu, 2013-06-20 22:58:19]

Actually easiest is to override PostCheckForRetroactiveBeginFrame in
SynchronousCompositorOutputSurface to no-op.

I think crbug.com/251909 says some of these logic will move to subclasses, so I
assume there will be some more legitimate way to enable/disable this behavior
from subclasses?

[brianderson, 2013-06-20 23:42:21]

lgtm once tests are added to verify SynchronousCompositor does not allow
retroactive BeginFrames.

https://codereview.chromium.org/17520002/diff/5001/content/browser/android/in...
File content/browser/android/in_process/synchronous_compositor_output_surface.cc
(right):

https://codereview.chromium.org/17520002/diff/5001/content/browser/android/in...
content/browser/android/in_process/synchronous_compositor_output_surface.cc:242:

nit: whitespace

[joth, 2013-06-21 02:45:37]

lgtm % brian's comment

[boliu, 2013-06-21 03:07:49]

Not going to add a test for this because this would be testing that a sequences
of calls executes the overriden method which does nothing. The sequence would be
brittle in the subclass method, and OVERRIDE already provide some safety.

Also looking at your begin frame patch, we might decide to use this retroactive
begin frame. I'll reply to that code review.

[commit-bot: I haz the power, 2013-06-21 05:51:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/17520002/12001

[commit-bot: I haz the power, 2013-06-21 05:51:57]

Change committed as 207723