Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 1751993004: Don't anti-alias clips in the Blink-replay path. (Closed)

Created:
4 years, 9 months ago by chrishtr
Modified:
4 years, 9 months ago
Reviewers:
f(malita)
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't anti-alias clips in the Blink-replay path. This is a workaround to unblock M49. BUG=590971 R=fmalita@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/8679e8bbd2de5b40e7f9b1c9cfc7585446caa0e6

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/layers/layer-canvas-log-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 25 (13 generated)
chrishtr
4 years, 9 months ago (2016-03-01 20:57:55 UTC) #3
chrishtr
It should be noted that this code path only runs for printing or other image-capture ...
4 years, 9 months ago (2016-03-01 20:59:45 UTC) #4
f(malita)
On 2016/03/01 20:59:45, chrishtr wrote: > It should be noted that this code path only ...
4 years, 9 months ago (2016-03-01 21:00:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751993004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751993004/1
4 years, 9 months ago (2016-03-01 21:18:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/133192) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 9 months ago (2016-03-01 22:15:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751993004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751993004/40001
4 years, 9 months ago (2016-03-01 22:59:31 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/138771) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-01 23:06:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751993004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751993004/60001
4 years, 9 months ago (2016-03-01 23:26:02 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/189904)
4 years, 9 months ago (2016-03-02 00:48:39 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751993004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751993004/60001
4 years, 9 months ago (2016-03-02 00:50:14 UTC) #21
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/8679e8bbd2de5b40e7f9b1c9cfc7585446caa0e6 Cr-Commit-Position: refs/heads/master@{#378635}
4 years, 9 months ago (2016-03-02 00:56:24 UTC) #23
chrishtr
4 years, 9 months ago (2016-03-02 00:57:01 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
8679e8bbd2de5b40e7f9b1c9cfc7585446caa0e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698