Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1751973003: Modernize Japanese system font fallback list for Windows (Closed)

Created:
4 years, 9 months ago by kojii
Modified:
4 years, 9 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modernize Japanese system font fallback list for Windows This patch changes Japanese system font fallback list for Winodws to prefer more modern, post-ClearType era fonts. This change improves font rendering of generic font families and system fallback on Windows for Japanese characters. This change may trigger hidden issues as these fonts includes internal leading in their font metrics. Such issues will be tracked separately as we find them. "Yu Gothic" is more modern than "Meiryo" and is the default font for Win10. However, its rendering, especially in Blink, is still suboptimal that this patch puts "Meiryo" higher than it. The font lists for katakanaOrHiragana, katakana, and hiragara are merged as ditiguishing them is not necessary. Also in order to ensure rebaselined images look sensible, added lang="ja" to tests with Japanese characters. Results for Win10 failures where this change affects are reviewed and removed Failure expectations, except track-cue-rendering-vertical.html that look to need more investigations. BUG=579842, 568030 Committed: https://crrev.com/bd2ce5625db55e8e3fe86a6aedc973d0f0bf22b3 Cr-Commit-Position: refs/heads/master@{#379189}

Patch Set 1 : Fix typo #

Patch Set 2 : Add lang=ja to some tests #

Patch Set 3 : TestExpectations #

Patch Set 4 : Rebase #

Patch Set 5 : TestExpectations #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -28 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 5 chunks +25 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dynamic/text-combine.html View 1 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/japanese-rl-selection-clear.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/japanese-rl-selection-repaint.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/ruby/base-shorter-than-text.html View 1 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/ruby/nested-ruby.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/international/001.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/international/003.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/international/vertical-text-metrics-test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/international/wrap-CJK-001.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/justify-ideograph-leading-expansion.html View 1 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/selection-multiple-runs.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/writing-mode/japanese-ruby-vertical-lr.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/writing-mode/japanese-ruby-vertical-rl.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-rendering-vertical.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp View 1 2 3 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
kojii
PTAL. Not sure how well this would work, but I think it's worth a try, ...
4 years, 9 months ago (2016-03-03 21:07:13 UTC) #6
eae
LGTM
4 years, 9 months ago (2016-03-03 23:07:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751973003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751973003/120001
4 years, 9 months ago (2016-03-04 02:45:46 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:120001)
4 years, 9 months ago (2016-03-04 02:51:41 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 02:53:05 UTC) #12
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/bd2ce5625db55e8e3fe86a6aedc973d0f0bf22b3
Cr-Commit-Position: refs/heads/master@{#379189}

Powered by Google App Engine
This is Rietveld 408576698