Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: lib/runtime/dart/collection.js

Issue 1751963002: refactor/simplify nullable inference code (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/src/codegen/assignments_index.dart » ('j') | lib/src/codegen/nullable_type_inference.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/collection.js
diff --git a/lib/runtime/dart/collection.js b/lib/runtime/dart/collection.js
index 6893355f6dccdf78b14d9e13693195330add727e..35ff705a774cb8750810faf69b1d07535751757a 100644
--- a/lib/runtime/dart/collection.js
+++ b/lib/runtime/dart/collection.js
@@ -987,12 +987,12 @@ dart_library.library('dart/collection', null, /* Imports */[
dart.assert(core.identical(IterableBase$()._toStringVisiting[dartx.last], iterable));
IterableBase$()._toStringVisiting[dartx.removeLast]();
}
- return dart.toString((() => {
+ return (() => {
let _ = new core.StringBuffer(leftDelimiter);
_.writeAll(parts, ", ");
_.write(rightDelimiter);
return _;
- })());
+ })().toString();
}
static iterableToFullString(iterable, leftDelimiter, rightDelimiter) {
if (leftDelimiter === void 0) leftDelimiter = '(';
@@ -1735,7 +1735,7 @@ dart_library.library('dart/collection', null, /* Imports */[
if (this[dartx.length] == 0) return "";
let buffer = new core.StringBuffer();
buffer.writeAll(this, separator);
- return dart.toString(buffer);
+ return buffer.toString();
}
[dartx.where](test) {
dart.as(test, dart.functionType(core.bool, [E]));
« no previous file with comments | « no previous file | lib/src/codegen/assignments_index.dart » ('j') | lib/src/codegen/nullable_type_inference.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698