Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1751953003: Remove the support of multiple shadow roots with a user agent shadow root (Closed)

Created:
4 years, 9 months ago by hayato
Modified:
4 years, 9 months ago
Reviewers:
tkent, yuzuchan, kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the support of multiple shadow roots with a user agent shadow root "Intent to Remove" is here: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/VKQk3uQuJLQ This CL removes the web-facing API, as a first step. The other removals, such as a cleanup of each element, will be done separately in other CLs. BUG=489947 Committed: https://crrev.com/3a686f1ed8e775db80511c61672f63685361387f Cr-Commit-Position: refs/heads/master@{#378921}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove an applet test #

Patch Set 3 : fix failing tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1396 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spellcheck-author-shadow-crash.html View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spellcheck-author-shadow-crash-expected.txt View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/multiple-shadowroot-with-params.html View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/multiple-shadowroot-with-params-expected.txt View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/olderShadowRoot.html View 2 chunks +0 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/olderShadowRoot-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/paint-input-range-crash.html View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable.html View 1 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt View 1 2 chunks +15 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-element-distributed-nodes.html View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-element-distributed-nodes-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-element-inactive.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-element-inactive-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-embed-with-content.html View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-embed-with-content-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-form-associated-element-useragent-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-input-appearance.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-input-appearance-expected.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-input-button-click.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-input-button-click-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-input-checkbox.html View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-input-checkbox-expected.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-input-color.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-input-color-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-input-file.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-input-file-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-input-range.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-input-range-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-input-spellcheck.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-input-spellcheck-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-input-type-change.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-input-type-change-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-only-shadow.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-only-shadow-expected.html View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-without-shadow.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-without-shadow-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-media.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-media-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-meter.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-meter-dynamic.html View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-meter-dynamic-expected.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-meter-expected.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-meter-multiple.html View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-meter-multiple-expected.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-meter-redistribute.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-meter-redistribute-expected.html View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-meter-with-style.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-meter-with-style-expected.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-meter-without-appearance.html View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-meter-without-appearance-expected.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-meter-without-shadow-element-expected.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-object-only-shadow.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-object-only-shadow-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-object-with-content.html View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-object-with-content-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-progress.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-progress-dynamic.html View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-progress-dynamic-expected.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-progress-expected.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-progress-multiple.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-progress-multiple-expected.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-progress-redistribute.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-progress-redistribute-expected.html View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-progress-with-style.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-progress-with-style-expected.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-progress-without-appearance.html View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-progress-without-appearance-expected.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-progress-without-shadow-element.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-progress-without-shadow-element-expected.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-select-only-shadow.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-select-only-shadow-expected.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-without-shadow.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-without-shadow-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-host.html View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-host-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/selectors/shadow-host-div-with-text.html View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/custom-elements.html View 1 2 4 chunks +1 line, -26 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/custom-elements-expected.html View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 35 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751953003/1
4 years, 9 months ago (2016-03-02 06:23:39 UTC) #2
hayato
PTAL
4 years, 9 months ago (2016-03-02 06:44:38 UTC) #7
tkent
https://codereview.chromium.org/1751953003/diff/1/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt File third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt (right): https://codereview.chromium.org/1751953003/diff/1/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt#newcode24 third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt:24: FAIL element.createShadowRoot() should throw an exception. Was [object ShadowRoot]. ...
4 years, 9 months ago (2016-03-02 06:52:20 UTC) #8
hayato
remove an applet test
4 years, 9 months ago (2016-03-02 07:04:02 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751953003/20001
4 years, 9 months ago (2016-03-02 07:04:10 UTC) #11
hayato
https://codereview.chromium.org/1751953003/diff/1/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt File third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt (right): https://codereview.chromium.org/1751953003/diff/1/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt#newcode24 third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt:24: FAIL element.createShadowRoot() should throw an exception. Was [object ShadowRoot]. ...
4 years, 9 months ago (2016-03-02 07:04:50 UTC) #12
tkent
lgtm
4 years, 9 months ago (2016-03-02 07:06:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751953003/20001
4 years, 9 months ago (2016-03-02 07:06:52 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/188993)
4 years, 9 months ago (2016-03-02 08:29:49 UTC) #18
hayato
Looks the following tests are failing. Let me fix these. svg/dom/custom-elements.html fast/selectors/shadow-host-div-with-text.html editing/spelling/spellcheck-author-shadow-crash.html imported/web-platform-tests/shadow-dom/untriaged/html-elements-and-their-shadow-trees/test-004.html
4 years, 9 months ago (2016-03-02 08:31:07 UTC) #19
hayato
fix failing tests
4 years, 9 months ago (2016-03-02 09:01:33 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751953003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751953003/40001
4 years, 9 months ago (2016-03-02 09:01:46 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 10:32:21 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751953003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751953003/40001
4 years, 9 months ago (2016-03-03 02:14:44 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-03 02:22:18 UTC) #29
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/3a686f1ed8e775db80511c61672f63685361387f Cr-Commit-Position: refs/heads/master@{#378921}
4 years, 9 months ago (2016-03-03 02:24:52 UTC) #31
kochi
will HTMLInputElement::willAddFirstAuthorShadowRoot() and the like be removed in future CLs?
4 years, 9 months ago (2016-03-03 02:37:53 UTC) #33
hayato
On 2016/03/03 02:37:53, kochi wrote: > will HTMLInputElement::willAddFirstAuthorShadowRoot() and the like > be removed in ...
4 years, 9 months ago (2016-03-03 04:19:26 UTC) #34
kochi
4 years, 9 months ago (2016-03-03 05:03:22 UTC) #35
Message was sent while issue was closed.
On 2016/03/03 04:19:26, hayato wrote:
> On 2016/03/03 02:37:53, kochi wrote:
> > will HTMLInputElement::willAddFirstAuthorShadowRoot() and the like
> > be removed in future CLs?
> 
> We should do it as the description of this CL says.

SGTM

Powered by Google App Engine
This is Rietveld 408576698