Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1751913002: Remove FX_NUM_DOUBLE (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove FX_NUM_DOUBLE This is never defined in the current code base. Remove. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/4d2ce6fe3f41d360fcebe0e0c3944dd22a971cd6

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -128 lines) Patch
M xfa/src/fgas/src/localization/fx_locale.cpp View 1 6 chunks +37 lines, -128 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dsinclair
PTAL.
4 years, 9 months ago (2016-03-01 14:47:34 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1751913002/diff/1/xfa/src/fgas/src/localization/fx_locale.cpp File xfa/src/fgas/src/localization/fx_locale.cpp (right): https://codereview.chromium.org/1751913002/diff/1/xfa/src/fgas/src/localization/fx_locale.cpp#newcode313 xfa/src/fgas/src/localization/fx_locale.cpp:313: bool bNegative = FALSE; nit: false (lowercase).
4 years, 9 months ago (2016-03-01 17:41:05 UTC) #3
dsinclair
https://codereview.chromium.org/1751913002/diff/1/xfa/src/fgas/src/localization/fx_locale.cpp File xfa/src/fgas/src/localization/fx_locale.cpp (right): https://codereview.chromium.org/1751913002/diff/1/xfa/src/fgas/src/localization/fx_locale.cpp#newcode313 xfa/src/fgas/src/localization/fx_locale.cpp:313: bool bNegative = FALSE; On 2016/03/01 17:41:05, Tom Sepez ...
4 years, 9 months ago (2016-03-01 17:50:04 UTC) #4
dsinclair
4 years, 9 months ago (2016-03-01 17:50:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4d2ce6fe3f41d360fcebe0e0c3944dd22a971cd6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698