Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 1751883004: SkFontHost_FreeType constructor to correctly release resources. (Closed)

Created:
3 years, 4 months ago by bungeman-skia
Modified:
3 years, 4 months ago
Reviewers:
herb_g, dogben
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkFontHost_FreeType constructor to correctly release resources. BUG=chromium:589848 Committed: https://skia.googlesource.com/skia/+/aabd71cc2c3313c51e618224426045f8573e69e6

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -21 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 8 chunks +37 lines, -21 lines 4 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751883004/1
3 years, 4 months ago (2016-03-01 22:17:12 UTC) #3
bungeman-skia
https://codereview.chromium.org/1751883004/diff/1/src/ports/SkFontHost_FreeType.cpp File src/ports/SkFontHost_FreeType.cpp (left): https://codereview.chromium.org/1751883004/diff/1/src/ports/SkFontHost_FreeType.cpp#oldcode905 src/ports/SkFontHost_FreeType.cpp:905: fFace = nullptr; The related bug was because we ...
3 years, 4 months ago (2016-03-01 22:28:06 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 4 months ago (2016-03-01 22:36:30 UTC) #7
herb_g
lgtm
3 years, 4 months ago (2016-03-01 23:13:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751883004/1
3 years, 4 months ago (2016-03-01 23:13:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/aabd71cc2c3313c51e618224426045f8573e69e6
3 years, 4 months ago (2016-03-01 23:15:13 UTC) #13
dogben
3 years, 4 months ago (2016-03-02 00:55:22 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/1751883004/diff/1/src/ports/SkFontHost_FreeTy...
File src/ports/SkFontHost_FreeType.cpp (right):

https://codereview.chromium.org/1751883004/diff/1/src/ports/SkFontHost_FreeTy...
src/ports/SkFontHost_FreeType.cpp:901: return size;
ignorable nit: Seems like it would be simpler to default-construct ftSize,
change the lambda to a block, and make this line ftSize.reset(size). Then also
remove the duplicate nullptr check below.

Powered by Google App Engine
This is Rietveld 408576698