Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1751843002: Also disable handle zapping for GN release BUILDS (Closed)

Created:
4 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.0
Target Ref:
refs/pending/branch-heads/5.0
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
jochen (gone - plz use gerrit)
4 years, 9 months ago (2016-03-01 10:38:44 UTC) #1
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-01 10:41:16 UTC) #2
jochen (gone - plz use gerrit)
4 years, 9 months ago (2016-03-01 10:44:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2371116af64d1d77e8bb5f26d55ea816b26d6bf2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698