Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: content/browser/cache_storage/cache_storage_unittest.cc

Issue 1751833002: Use string16 for cache_name in the back end of CacheStorage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/cache_storage/cache_storage_unittest.cc
diff --git a/content/browser/cache_storage/cache_storage_unittest.cc b/content/browser/cache_storage/cache_storage_unittest.cc
index faf0eb10635b87b59c3f83c1088bd4c1a6452f5e..764b75f17273cce36ab346a6711da0fe56e7f7e5 100644
--- a/content/browser/cache_storage/cache_storage_unittest.cc
+++ b/content/browser/cache_storage/cache_storage_unittest.cc
@@ -9,6 +9,7 @@
#include "base/files/scoped_temp_dir.h"
#include "base/run_loop.h"
#include "base/stl_util.h"
+#include "base/strings/utf_string_conversions.h"
#include "base/thread_task_runner_handle.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "net/url_request/url_request_context_getter.h"
@@ -73,8 +74,9 @@ class CacheStorageTest : public testing::Test {
bool OpenCache(const std::string& cache_name) {
bool callback_called = false;
test_cache_storage_->OpenCache(
- cache_name, base::Bind(&CacheStorageTest::OpenCacheCallback,
- base::Unretained(this), &callback_called));
+ base::UTF8ToUTF16(cache_name),
+ base::Bind(&CacheStorageTest::OpenCacheCallback, base::Unretained(this),
+ &callback_called));
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(callback_called);
return callback_error_ == CACHE_STORAGE_OK;

Powered by Google App Engine
This is Rietveld 408576698