Analysis server connect fixes

pkg/analysis_server/lib/src/analysis_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis.server;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/analysis_logger.dart';
 import 'package:analysis_server/src/channel.dart';
@@ skipping 17 matching lines @@
 
   /**
    * The name of the parameter whose value is a source.
    */
   static const String SOURCE_PARAM = 'source';
 
   /**
    * The channel from which requests are received and to which responses should
    * be sent.
    */
-  CommunicationChannel channel;
+  final CommunicationChannel channel;
 
   /**
    * A flag indicating whether the server is running.
    */
   bool running;
 
   /**
    * A list of the request handlers used to handle the requests sent to this
    * server.
    */
   List<RequestHandler> handlers;
 
   /**
    * A table mapping context id's to the analysis contexts associated with them.
    */
   final Map<String, AnalysisContext> contextMap = new Map<String, AnalysisContext>();
 
   /**
    * A list of the analysis contexts for which analysis work needs to be
    * performed.
    */
   final List<AnalysisContext> contextWorkQueue = new List<AnalysisContext>();
 
   /**
    * Initialize a newly created server to receive requests from and send
    * responses to the given [channel].
    */
-  AnalysisServer(CommunicationChannel channel) {
+  AnalysisServer(this.channel) {
     AnalysisEngine.instance.logger = new AnalysisLogger();
     running = true;
-    this.channel = channel;
-    this.channel.listen(handleRequest, onError: error, onDone: done);
+    // TODO set running=false on done or error
+    channel.listen(handleRequest);
   }
 
   /**
    * Add the given [context] to the list of analysis contexts for which analysis
    * work needs to be performed. Ensure that the work will be performed.
    */
   void addContextToWorkQueue(AnalysisContext context) {
     if (!contextWorkQueue.contains(context)) {
       contextWorkQueue.add(context);
       run();
@@ skipping 87 matching lines @@
     }
   }
 
   /**
    * Send the given [notification] to the client.
    */
   void sendNotification(Notification notification) {
     channel.sendNotification(notification);
   }
 }