ARC: Remove error status setting in GetNetworks.

components/arc/net/arc_net_host_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/net/arc_net_host_impl.h"
 
 #include <string>
 #include <vector>
 
 #include "base/location.h"
@@ skipping 34 matching lines @@
 }
 
 void ArcNetHostImpl::OnNetInstanceReady() {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   NetHostPtr host;
   binding_.Bind(GetProxy(&host));
   arc_bridge_service()->net_instance()->Init(std::move(host));
 }
 
-void ArcNetHostImpl::GetNetworks(bool configured_only,
-                                 bool visible_only,
+void ArcNetHostImpl::GetNetworksDeprecated(
+    bool configured_only,
+    bool visible_only,
+    const GetNetworksDeprecatedCallback& callback) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  if (configured_only && visible_only) {
+    VLOG(1) << "Illegal arguments - both configured and visible networks "
+               "requested.";
+    return;
+  }
+
+  GetNetworksRequestType type = GetNetworksRequestType::CONFIGURED_ONLY;
+  if (visible_only) {
+    type = GetNetworksRequestType::VISIBLE_ONLY;
+  }
+
+  GetNetworks(type, callback);
+}
+
+void ArcNetHostImpl::GetNetworks(GetNetworksRequestType type,
                                  const GetNetworksCallback& callback) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+
   NetworkDataPtr data = NetworkData::New();
-  data->status = NetworkResult::SUCCESS;
+  bool configured_only = true;
+  bool visible_only = false;
+  if (type == GetNetworksRequestType::VISIBLE_ONLY) {
+    configured_only = false;
+    visible_only = true;
+  }

[dcheng, 2016/03/03 05:56:20]

It might be slightly shorter to just write:

bool configured_only = type == GetNetworksRequestType::CONFIGURED_ONLY;
bool visible_only = type == GetNetworksRequestType::VISIBLE_ONLY;

 
   // Retrieve list of nearby wifi networks
   chromeos::NetworkTypePattern network_pattern =
       chromeos::onc::NetworkTypePatternFromOncType(onc::network_type::kWiFi);
   scoped_ptr<base::ListValue> network_properties_list =
       chromeos::network_util::TranslateNetworkListToONC(
           network_pattern, configured_only, visible_only,
           kGetNetworksListLimit);
 
   // Extract info for each network and add it to the list.
@@ skipping 55 matching lines @@
   }
 
   arc_bridge_service()->net_instance()->ScanCompleted();
 }
 
 void ArcNetHostImpl::OnShuttingDown() {
   GetStateHandler()->RemoveObserver(this, FROM_HERE);
 }
 
 }  // namespace arc