ARC: Remove error status setting in GetNetworks.

components/arc/net/arc_net_host_impl.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_NET_ARC_NET_HOST_IMPL_H_
 #define COMPONENTS_ARC_NET_ARC_NET_HOST_IMPL_H_
 
 #include <stdint.h>
 #include <string>
 #include <vector>
 
 #include "base/files/scoped_file.h"
 #include "base/macros.h"
+#include "base/synchronization/lock.h"
 #include "base/threading/thread_checker.h"
 #include "chromeos/network/network_state_handler_observer.h"
 #include "components/arc/arc_bridge_service.h"
 #include "components/arc/arc_service.h"
 #include "components/arc/common/net.mojom.h"
+#include "mojo/public/cpp/bindings/array.h"
 #include "mojo/public/cpp/bindings/binding.h"
 
 namespace arc {
 
 class ArcBridgeService;
 
 // Private implementation of ArcNetHost.
 class ArcNetHostImpl : public ArcService,
                        public ArcBridgeService::Observer,
                        public chromeos::NetworkStateHandlerObserver,
                        public NetHost {
  public:
   // The constructor will register an Observer with ArcBridgeService.
   explicit ArcNetHostImpl(ArcBridgeService* arc_bridge_service);
   ~ArcNetHostImpl() override;
 
   // Called when a GetNetworks call is sent from ARC.
   void GetNetworks(bool configured_only,
                    bool visible_only,
                    const GetNetworksCallback& callback) override;
 
   // Called when a GetWifiEnabledState call is sent from ARC.
   void GetWifiEnabledState(
       const GetWifiEnabledStateCallback& callback) override;
 
   // Called when a StartScan call is sent from ARC.
   void StartScan() override;
 
   // Overriden from chromeos::NetworkStateHandlerObserver.
   void ScanCompleted(const chromeos::DeviceState* /*unused*/) override;

[Luis Héctor Chávez, 2016/03/01 16:22:31]

Can you comment about what thread this is expected to be called as?

 
   // Overriden from chromeos::NetworkStateHandlerObserver.
   void OnShuttingDown() override;
 
   // Overridden from ArcBridgeService::Observer:
   void OnNetInstanceReady() override;
 
+  // Overridden from ArcBridgeService::Observer:
+  void OnNetInstanceClosed() override;
+
  private:
   base::ThreadChecker thread_checker_;
   mojo::Binding<arc::NetHost> binding_;
 
+  // Lock to synchronize access to the cached list of visible networks.
+  base::Lock visible_networks_lock_;
+
+  // List of visible networks that will be sent across to the instance. This
+  // will be cached in the call to GetNetworks and invalidated when a
+  // ScanCompleted notification is received.
+  mojo::Array<arc::WifiConfigurationPtr> cached_visible_networks_;

[Luis Héctor Chávez, 2016/03/01 16:22:31]

I don't love the idea of a move-only collection being used as a cache and then
cloned every time you want to send it over. Given that you still need to do
copying, would it make sense to make it a std::vector<arc::WifiConfiguration>?

+
   DISALLOW_COPY_AND_ASSIGN(ArcNetHostImpl);
 };
 
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_NET_ARC_NET_HOST_IMPL_H_