Remove implicit conversions and some cleanup

core/include/fpdfdoc/fpdf_doc.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_INCLUDE_FPDFDOC_FPDF_DOC_H_
 #define CORE_INCLUDE_FPDFDOC_FPDF_DOC_H_
 
 #include <map>
@@ skipping 26 matching lines @@
 class CPDF_NumberTree;
 class CPDF_OCContext;
 class CPDF_Page;
 class CPDF_RenderOptions;
 class CPDF_TextObject;
 class CPDF_ViewerPreferences;
 class CXML_Element;
 
 class CPDF_NameTree {
  public:
-  explicit CPDF_NameTree(CPDF_Dictionary* pRoot) { m_pRoot = pRoot; }
-
+  explicit CPDF_NameTree(CPDF_Dictionary* pRoot) : m_pRoot(pRoot) {}
   CPDF_NameTree(CPDF_Document* pDoc, const CFX_ByteStringC& category);
 
   CPDF_Object* LookupValue(int nIndex, CFX_ByteString& csName) const;
-
   CPDF_Object* LookupValue(const CFX_ByteString& csName) const;
-
   CPDF_Array* LookupNamedDest(CPDF_Document* pDoc,
                               const CFX_ByteStringC& sName);
-
   int GetIndex(const CFX_ByteString& csName) const;
-
   int GetCount() const;
-
   CPDF_Dictionary* GetRoot() const { return m_pRoot; }
 
  protected:
   CPDF_Dictionary* m_pRoot;
 };
+
 class CPDF_BookmarkTree {
  public:
   explicit CPDF_BookmarkTree(CPDF_Document* pDoc) : m_pDocument(pDoc) {}
 
   CPDF_Bookmark GetFirstChild(const CPDF_Bookmark& parent) const;
-
   CPDF_Bookmark GetNextSibling(const CPDF_Bookmark& bookmark) const;
-
   CPDF_Document* GetDocument() const { return m_pDocument; }
 
  protected:
-  CPDF_Document* m_pDocument;
+  CPDF_Document* const m_pDocument;
 };
+
 #define PDFBOOKMARK_ITALIC 1
 #define PDFBOOKMARK_BOLD 2
 class CPDF_Bookmark {
  public:
-  CPDF_Bookmark() : m_pDict(NULL) {}
-
+  CPDF_Bookmark() : m_pDict(nullptr) {}
   explicit CPDF_Bookmark(CPDF_Dictionary* pDict) : m_pDict(pDict) {}
 
   CPDF_Dictionary* GetDict() const { return m_pDict; }
-
-  operator bool() const { return m_pDict != NULL; }
-
   FX_DWORD GetColorRef() const;
-
   FX_DWORD GetFontStyle() const;
-
   CFX_WideString GetTitle() const;
-
   CPDF_Dest GetDest(CPDF_Document* pDocument) const;
-
   CPDF_Action GetAction() const;
 
+ protected:
   CPDF_Dictionary* m_pDict;
 };
+
 #define PDFZOOM_XYZ 1
 #define PDFZOOM_FITPAGE 2
 #define PDFZOOM_FITHORZ 3
 #define PDFZOOM_FITVERT 4
 #define PDFZOOM_FITRECT 5
 #define PDFZOOM_FITBBOX 6
 #define PDFZOOM_FITBHORZ 7
 #define PDFZOOM_FITBVERT 8
 class CPDF_Dest {
  public:
   CPDF_Dest() : m_pObj(nullptr) {}
   explicit CPDF_Dest(CPDF_Object* pObj) : m_pObj(pObj) {}
 
-  operator bool() const { return m_pObj != NULL; }
   CPDF_Object* GetObject() const { return m_pObj; }
-
   CFX_ByteString GetRemoteName();
   int GetPageIndex(CPDF_Document* pDoc);
   FX_DWORD GetPageObjNum();
   int GetZoomMode();
   FX_FLOAT GetParam(int index);
 
  protected:
   CPDF_Object* m_pObj;
 };
+
 class CPDF_OCContext : public IPDF_OCContext {
  public:
   enum UsageType { View = 0, Design, Print, Export };
 
   explicit CPDF_OCContext(CPDF_Document* pDoc, UsageType eUsageType = View);
   ~CPDF_OCContext() override;
 
+  // IPDF_OCContext:
+  FX_BOOL CheckOCGVisible(const CPDF_Dictionary* pOCGDict) override;
+
   CPDF_Document* GetDocument() const { return m_pDocument; }
-
   UsageType GetUsageType() const { return m_eUsageType; }
 
-  FX_BOOL CheckOCGVisible(const CPDF_Dictionary* pOCGDict) override;
-
   void ResetOCContext();
 
  protected:
   FX_BOOL LoadOCGStateFromConfig(const CFX_ByteStringC& csConfig,
                                  const CPDF_Dictionary* pOCGDict,
                                  FX_BOOL& bValidConfig) const;
-
   FX_BOOL LoadOCGState(const CPDF_Dictionary* pOCGDict) const;
-
   FX_BOOL GetOCGVisible(const CPDF_Dictionary* pOCGDict);
-
   FX_BOOL GetOCGVE(CPDF_Array* pExpression,
                    FX_BOOL bFromConfig,
                    int nLevel = 0);
-
   FX_BOOL LoadOCMDState(const CPDF_Dictionary* pOCMDDict, FX_BOOL bFromConfig);
 
   CPDF_Document* m_pDocument;
-
   UsageType m_eUsageType;
-
   std::map<const CPDF_Dictionary*, FX_BOOL> m_OCGStates;
 };
 
 class CPDF_ActionFields {
  public:
-  // TODO(thestig): Examine why this cannot be explicit.
-  CPDF_ActionFields(const CPDF_Action* pAction) {
-    m_pAction = (CPDF_Action*)pAction;
-  }
-
-  // TODO(thestig): Replace this.
-  operator CPDF_Action*() const { return m_pAction; }
+  explicit CPDF_ActionFields(const CPDF_Action* pAction) : m_pAction(pAction) {}
 
   FX_DWORD GetFieldsCount() const;
-
   std::vector<CPDF_Object*> GetAllFields() const;
-
   CPDF_Object* GetField(FX_DWORD iIndex) const;
 
-  CPDF_Action* m_pAction;
+ protected:
+  const CPDF_Action* const m_pAction;
 };
 
 #define PDFNAMED_NEXTPAGE 1
 #define PDFNAMED_PREVPAGE 2
 #define PDFNAMED_FIRSTPAGE 3
 #define PDFNAMED_LASTPAGE 4
 #define PDFJS_MAXLENGTH 64
 class CPDF_Action {
  public:
   enum ActionType {
@@ skipping 14 matching lines @@
     JavaScript,
     SetOCGState,
     Rendition,
     Trans,
     GoTo3DView
   };
 
   CPDF_Action() : m_pDict(nullptr) {}
   explicit CPDF_Action(CPDF_Dictionary* pDict) : m_pDict(pDict) {}
 
-  operator bool() const { return m_pDict != NULL; }
-
   CPDF_Dictionary* GetDict() const { return m_pDict; }
-
   CFX_ByteString GetTypeName() const { return m_pDict->GetStringBy("S"); }
-
   ActionType GetType() const;
-
   CPDF_Dest GetDest(CPDF_Document* pDoc) const;
-
   CFX_WideString GetFilePath() const;
-
   FX_BOOL GetNewWindow() const { return m_pDict->GetBooleanBy("NewWindow"); }
-
   CFX_ByteString GetURI(CPDF_Document* pDoc) const;
-
   FX_BOOL GetMouseMap() const { return m_pDict->GetBooleanBy("IsMap"); }
-
-  CPDF_ActionFields GetWidgets() const { return this; }
-
   FX_BOOL GetHideStatus() const { return m_pDict->GetBooleanBy("H", TRUE); }
-
   CFX_ByteString GetNamedAction() const { return m_pDict->GetStringBy("N"); }
-
   FX_DWORD GetFlags() const { return m_pDict->GetIntegerBy("Flags"); }
-
   CFX_WideString GetJavaScript() const;
-
   CPDF_Dictionary* GetAnnot() const;
-
   int32_t GetOperationType() const;
-
   CPDF_Stream* GetSoundStream() const { return m_pDict->GetStreamBy("Sound"); }
-
   FX_FLOAT GetVolume() const { return m_pDict->GetNumberBy("Volume"); }
-
   FX_BOOL IsSynchronous() const { return m_pDict->GetBooleanBy("Synchronous"); }
-
   FX_BOOL IsRepeat() const { return m_pDict->GetBooleanBy("Repeat"); }
-
   FX_BOOL IsMixPlay() const { return m_pDict->GetBooleanBy("Mix"); }
-
   FX_DWORD GetSubActionsCount() const;
-
   CPDF_Action GetSubAction(FX_DWORD iIndex) const;
 
  protected:
-  CPDF_Dictionary* m_pDict;
+  CPDF_Dictionary* const m_pDict;
 };
+
 class CPDF_AAction {
  public:
-  // TODO(thestig): Examine why this cannot be explicit.
-  CPDF_AAction(CPDF_Dictionary* pDict = NULL) { m_pDict = pDict; }
-
-  operator CPDF_Dictionary*() const { return m_pDict; }
-
   enum AActionType {
     CursorEnter = 0,
     CursorExit,
     ButtonDown,
     ButtonUp,
     GetFocus,
     LoseFocus,
     PageOpen,
     PageClose,
     PageVisible,
     PageInvisible,
     OpenPage,
     ClosePage,
     KeyStroke,
     Format,
     Validate,
     Calculate,
     CloseDocument,
     SaveDocument,
     DocumentSaved,
     PrintDocument,
     DocumentPrinted
   };
 
+  CPDF_AAction() : m_pDict(nullptr) {}
+  explicit CPDF_AAction(CPDF_Dictionary* pDict) : m_pDict(pDict) {}
+
   FX_BOOL ActionExist(AActionType eType) const;
+  CPDF_Action GetAction(AActionType eType) const;
+  CPDF_Dictionary* GetDict() const { return m_pDict; }
 
-  CPDF_Action GetAction(AActionType eType) const;
+ protected:
+  CPDF_Dictionary* const m_pDict;
+};
 
-  CPDF_Dictionary* m_pDict;
-};
 class CPDF_DocJSActions {
  public:
   explicit CPDF_DocJSActions(CPDF_Document* pDoc);
 
   int CountJSActions() const;
-
   CPDF_Action GetJSAction(int index, CFX_ByteString& csName) const;
-
   CPDF_Action GetJSAction(const CFX_ByteString& csName) const;
-
   int FindJSAction(const CFX_ByteString& csName) const;
-
   CPDF_Document* GetDocument() const { return m_pDocument; }
 
  protected:
   CPDF_Document* const m_pDocument;
 };
 
 class CPDF_FileSpec {
  public:
   CPDF_FileSpec();
-  explicit CPDF_FileSpec(CPDF_Object* pObj) { m_pObj = pObj; }
+  explicit CPDF_FileSpec(CPDF_Object* pObj) : m_pObj(pObj) {}
 
   // Convert a platform dependent file name into pdf format.
   static CFX_WideString EncodeFileName(const CFX_WideStringC& filepath);
 
   // Convert a pdf file name into platform dependent format.
   static CFX_WideString DecodeFileName(const CFX_WideStringC& filepath);
 
   CPDF_Object* GetObj() const { return m_pObj; }
   bool GetFileName(CFX_WideString* wsFileName) const;
 
   // Set this file spec to refer to a file name (not a url).
   void SetFileName(const CFX_WideStringC& wsFileName);
 
  protected:
   CPDF_Object* m_pObj;
 };
 
 class CPDF_LinkList {
  public:
   CPDF_LinkList();
   ~CPDF_LinkList();
 
   CPDF_Link GetLinkAtPoint(CPDF_Page* pPage,
                            FX_FLOAT pdf_x,
                            FX_FLOAT pdf_y,
                            int* z_order);
 
  private:
   const std::vector<CPDF_Dictionary*>* GetPageLinks(CPDF_Page* pPage);
-
   void LoadPageLinks(CPDF_Page* pPage, std::vector<CPDF_Dictionary*>* pList);
 
   std::map<FX_DWORD, std::vector<CPDF_Dictionary*>> m_PageMap;
 };
 
 class CPDF_Link {
  public:
   CPDF_Link() : m_pDict(nullptr) {}
   explicit CPDF_Link(CPDF_Dictionary* pDict) : m_pDict(pDict) {}
 
@@ skipping 18 matching lines @@
 #define ANNOTFLAG_TOGGLENOVIEW 0x0100
 
 class CPDF_Annot : public CFX_PrivateData {
  public:
   enum AppearanceMode { Normal, Rollover, Down };
 
   CPDF_Annot(CPDF_Dictionary* pDict, CPDF_AnnotList* pList);
   ~CPDF_Annot();
 
   CFX_ByteString GetSubType() const;
-
   FX_DWORD GetFlags() const;
-
   void GetRect(CFX_FloatRect& rect) const;
-
   const CPDF_Dictionary* GetAnnotDict() const { return m_pAnnotDict; }
   CPDF_Dictionary* GetAnnotDict() { return m_pAnnotDict; }
-
   FX_BOOL DrawAppearance(CPDF_Page* pPage,
                          CFX_RenderDevice* pDevice,
                          const CFX_Matrix* pUser2Device,
                          AppearanceMode mode,
                          const CPDF_RenderOptions* pOptions);
-
   FX_BOOL DrawInContext(const CPDF_Page* pPage,
                         CPDF_RenderContext* pContext,
                         const CFX_Matrix* pUser2Device,
                         AppearanceMode mode);
-
   void ClearCachedAP();
-
   void DrawBorder(CFX_RenderDevice* pDevice,
                   const CFX_Matrix* pUser2Device,
                   const CPDF_RenderOptions* pOptions);
-
   CPDF_Form* GetAPForm(const CPDF_Page* pPage, AppearanceMode mode);
 
  private:
   CPDF_Dictionary* const m_pAnnotDict;
   CPDF_AnnotList* const m_pList;
   const CFX_ByteString m_sSubtype;
   std::map<CPDF_Stream*, CPDF_Form*> m_APMap;
 };
 
 class CPDF_AnnotList {
  public:
   explicit CPDF_AnnotList(CPDF_Page* pPage);
   ~CPDF_AnnotList();
 
   void DisplayAnnots(CPDF_Page* pPage,
                      CPDF_RenderContext* pContext,
                      FX_BOOL bPrinting,
                      CFX_Matrix* pMatrix,
                      FX_BOOL bShowWidget,
                      CPDF_RenderOptions* pOptions) {
     DisplayAnnots(pPage, nullptr, pContext, bPrinting, pMatrix,
                   bShowWidget ? 3 : 1, pOptions, nullptr);
   }
+
   void DisplayAnnots(CPDF_Page* pPage,
                      CFX_RenderDevice* pDevice,
                      CPDF_RenderContext* pContext,
                      FX_BOOL bPrinting,
                      CFX_Matrix* pMatrix,
                      FX_DWORD dwAnnotFlags,
                      CPDF_RenderOptions* pOptions,
                      FX_RECT* pClipRect);
   size_t Count() const { return m_AnnotList.size(); }
   CPDF_Annot* GetAt(size_t index) const { return m_AnnotList[index]; }
@@ skipping 13 matching lines @@
   CPDF_Document* const m_pDocument;
   std::vector<CPDF_Annot*> m_AnnotList;
 };
 
 #define COLORTYPE_TRANSPARENT 0
 #define COLORTYPE_GRAY 1
 #define COLORTYPE_RGB 2
 #define COLORTYPE_CMYK 3
 class CPDF_DefaultAppearance {
  public:
-  // TODO(thestig): Examine why this cannot be explicit.
-  CPDF_DefaultAppearance(const CFX_ByteString& csDA = "") { m_csDA = csDA; }
+  CPDF_DefaultAppearance() {}
+  explicit CPDF_DefaultAppearance(const CFX_ByteString& csDA) : m_csDA(csDA) {}
 
   CPDF_DefaultAppearance(const CPDF_DefaultAppearance& cDA) {
-    m_csDA = (CFX_ByteString)(CPDF_DefaultAppearance&)cDA;
+    m_csDA = cDA.GetStr();
   }
 
-  operator CFX_ByteString() const { return m_csDA; }
-
-  const CPDF_DefaultAppearance& operator=(const CFX_ByteString& csDA) {
-    m_csDA = csDA;
-    return *this;
-  }
-
-  const CPDF_DefaultAppearance& operator=(const CPDF_DefaultAppearance& cDA) {
-    m_csDA = (CFX_ByteString)(CPDF_DefaultAppearance&)cDA;
-    return *this;
-  }
-
+  CFX_ByteString GetStr() const { return m_csDA; }
   FX_BOOL HasFont();
-
   CFX_ByteString GetFontString();
-
   void GetFont(CFX_ByteString& csFontNameTag, FX_FLOAT& fFontSize);
-
   FX_BOOL HasColor(FX_BOOL bStrokingOperation = FALSE);
-
   CFX_ByteString GetColorString(FX_BOOL bStrokingOperation = FALSE);
-
   void GetColor(int& iColorType,
                 FX_FLOAT fc[4],
                 FX_BOOL bStrokingOperation = FALSE);
-
   void GetColor(FX_ARGB& color,
                 int& iColorType,
                 FX_BOOL bStrokingOperation = FALSE);
-
   FX_BOOL HasTextMatrix();
-
   CFX_ByteString GetTextMatrixString();
-
   CFX_Matrix GetTextMatrix();
 
  protected:
   CFX_ByteString m_csDA;
 };
+
 #define FIELDTYPE_UNKNOWN 0
 #define FIELDTYPE_PUSHBUTTON 1
 #define FIELDTYPE_CHECKBOX 2
 #define FIELDTYPE_RADIOBUTTON 3
 #define FIELDTYPE_COMBOBOX 4
 #define FIELDTYPE_LISTBOX 5
 #define FIELDTYPE_TEXTFIELD 6
 #define FIELDTYPE_SIGNATURE 7
 class CPDF_InterForm : public CFX_PrivateData {
  public:
   CPDF_InterForm(CPDF_Document* pDocument, FX_BOOL bUpdateAP);
   ~CPDF_InterForm();
 
   static void EnableUpdateAP(FX_BOOL bUpdateAP);
 
   static FX_BOOL UpdatingAPEnabled();
 
   static CFX_ByteString GenerateNewResourceName(const CPDF_Dictionary* pResDict,
                                                 const FX_CHAR* csType,
                                                 int iMinLen = 2,
                                                 const FX_CHAR* csPrefix = "");
 
   static CPDF_Font* AddStandardFont(CPDF_Document* pDocument,
                                     CFX_ByteString csFontName);
 
-  static CFX_ByteString GetNativeFont(uint8_t iCharSet, void* pLogFont = NULL);
+  static CFX_ByteString GetNativeFont(uint8_t iCharSet,
+                                      void* pLogFont = nullptr);
 
-  static CFX_ByteString GetNativeFont(void* pLogFont = NULL);
+  static CFX_ByteString GetNativeFont(void* pLogFont = nullptr);
 
   static uint8_t GetNativeCharSet();
 
   static CPDF_Font* AddNativeFont(uint8_t iCharSet, CPDF_Document* pDocument);
 
   static CPDF_Font* AddNativeFont(CPDF_Document* pDocument);
 
   FX_BOOL ValidateFieldName(CFX_WideString& csNewFieldName, int iType);
 
   FX_BOOL ValidateFieldName(const CPDF_FormField* pField,
@@ skipping 141 matching lines @@
   std::unique_ptr<CFieldTree> m_pFieldTree;
 
   CFX_ByteString m_bsEncoding;
 
   CPDF_FormNotify* m_pFormNotify;
 
   FX_BOOL m_bUpdated;
   friend class CPDF_FormControl;
   friend class CPDF_FormField;
 };
+
 #define FORMFIELD_READONLY 0x01
 #define FORMFIELD_REQUIRED 0x02
 #define FORMFIELD_NOEXPORT 0x04
 #define FORMRADIO_NOTOGGLEOFF 0x100
 #define FORMRADIO_UNISON 0x200
 #define FORMTEXT_MULTILINE 0x100
 #define FORMTEXT_PASSWORD 0x200
 #define FORMTEXT_NOSCROLL 0x400
 #define FORMTEXT_COMB 0x800
 #define FORMCOMBO_EDIT 0x100
@@ skipping 137 matching lines @@
   FX_DWORD m_Flags;
   CPDF_InterForm* m_pForm;
   CPDF_Dictionary* m_pDict;
   CFX_ArrayTemplate<CPDF_FormControl*> m_ControlList;
   FX_FLOAT m_FontSize;
   CPDF_Font* m_pFont;
 
   friend class CPDF_InterForm;
   friend class CPDF_FormControl;
 };
+
 CPDF_Object* FPDF_GetFieldAttr(CPDF_Dictionary* pFieldDict,
                                const FX_CHAR* name,
                                int nLevel = 0);
 class CPDF_IconFit {
  public:
-  // TODO(thestig): Examine why this cannot be explicit.
-  CPDF_IconFit(CPDF_Dictionary* pDict = NULL) { m_pDict = pDict; }
-
-  operator CPDF_Dictionary*() const { return m_pDict; }
-
   enum ScaleMethod { Always = 0, Bigger, Smaller, Never };
 
+  explicit CPDF_IconFit(const CPDF_Dictionary* pDict) : m_pDict(pDict) {}
+
   ScaleMethod GetScaleMethod();
+  FX_BOOL IsProportionalScale();
+  void GetIconPosition(FX_FLOAT& fLeft, FX_FLOAT& fBottom);
+  FX_BOOL GetFittingBounds();
+  const CPDF_Dictionary* GetDict() const { return m_pDict; }
 
-  FX_BOOL IsProportionalScale();
-
-  void GetIconPosition(FX_FLOAT& fLeft, FX_FLOAT& fBottom);
-
-  FX_BOOL GetFittingBounds();
-
-  CPDF_Dictionary* m_pDict;
+ protected:
+  const CPDF_Dictionary* const m_pDict;
 };
 
 #define TEXTPOS_CAPTION 0
 #define TEXTPOS_ICON 1
 #define TEXTPOS_BELOW 2
 #define TEXTPOS_ABOVE 3
 #define TEXTPOS_RIGHT 4
 #define TEXTPOS_LEFT 5
 #define TEXTPOS_OVERLAID 6
 
 class CPDF_FormControl {
  public:
   enum HighlightingMode { None = 0, Invert, Outline, Push, Toggle };
 
   CPDF_FormField::Type GetType() const { return m_pField->GetType(); }
   CPDF_InterForm* GetInterForm() const { return m_pForm; }
   CPDF_FormField* GetField() const { return m_pField; }
   CPDF_Dictionary* GetWidget() const { return m_pWidgetDict; }
   CFX_FloatRect GetRect() const;
 
   void DrawControl(CFX_RenderDevice* pDevice,
                    CFX_Matrix* pMatrix,
                    CPDF_Page* pPage,
                    CPDF_Annot::AppearanceMode mode,
-                   const CPDF_RenderOptions* pOptions = NULL);
+                   const CPDF_RenderOptions* pOptions = nullptr);
 
   CFX_ByteString GetCheckedAPState();
   CFX_WideString GetExportValue();
 
   bool IsChecked() const;
   bool IsDefaultChecked() const;
 
   HighlightingMode GetHighlightingMode();
   bool HasMKEntry(CFX_ByteString csEntry) const;
   int GetRotation();
@@ skipping 94 matching lines @@
   }
   virtual void AfterSelectionChange(CPDF_FormField* pField) {}
   virtual void AfterCheckedStatusChange(CPDF_FormField* pField) {}
   virtual int BeforeFormReset(CPDF_InterForm* pForm) { return 0; }
   virtual void AfterFormReset(CPDF_InterForm* pForm) {}
   virtual int BeforeFormImportData(CPDF_InterForm* pForm) { return 0; }
   virtual void AfterFormImportData(CPDF_InterForm* pForm) {}
 };
 
 FX_BOOL FPDF_GenerateAP(CPDF_Document* pDoc, CPDF_Dictionary* pAnnotDict);
+
 class CPDF_PageLabel {
  public:
-  explicit CPDF_PageLabel(CPDF_Document* pDocument) { m_pDocument = pDocument; }
+  explicit CPDF_PageLabel(CPDF_Document* pDocument) : m_pDocument(pDocument) {}
 
   CFX_WideString GetLabel(int nPage) const;
-
   int32_t GetPageByLabel(const CFX_ByteStringC& bsLabel) const;
-
   int32_t GetPageByLabel(const CFX_WideStringC& wsLabel) const;
 
  protected:
-  CPDF_Document* m_pDocument;
+  CPDF_Document* const m_pDocument;
 };
 
 class CPDF_Metadata {
  public:
   explicit CPDF_Metadata(CPDF_Document* pDoc);
   ~CPDF_Metadata();
 
   const CXML_Element* GetRoot() const;
 
  private:
   std::unique_ptr<CXML_Element> m_pXmlElement;
 };
 
 class CPDF_ViewerPreferences {
  public:
   explicit CPDF_ViewerPreferences(CPDF_Document* pDoc);
-
   ~CPDF_ViewerPreferences();
 
   FX_BOOL IsDirectionR2L() const;
-
   FX_BOOL PrintScaling() const;
-
   int32_t NumCopies() const;
-
   CPDF_Array* PrintPageRange() const;
-
   CFX_ByteString Duplex() const;
 
  protected:
   CPDF_Document* const m_pDoc;
 };
 
 class CPDF_ApSettings {
  public:
   explicit CPDF_ApSettings(CPDF_Dictionary* pDict);
 
@@ skipping 54 matching lines @@
   CFX_WideString GetCaption(const CFX_ByteStringC& csEntry) const;
 
   CPDF_Stream* GetIcon(const CFX_ByteStringC& csEntry) const;
 
   CPDF_Dictionary* const m_pDict;
 };
 
 CFX_WideString FILESPEC_EncodeFileName(const CFX_WideStringC& filepath);
 
 #endif  // CORE_INCLUDE_FPDFDOC_FPDF_DOC_H_