Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 1751733002: Remove CertVerifyProcTest.CybertrustGTERoot unit test (Closed)

Created:
4 years, 9 months ago by Ryan Sleevi
Modified:
4 years, 9 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CertVerifyProcTest.CybertrustGTERoot unit test This test originally tested a CA-specific workaround in chain building. However, due to more OS X "quirks", the CA-specific workaround was replaced with a CA-agnostic one. While this unit test did provide some value for the specific CA test, it was only relevant on pre-10.9 systems anyways; with OS X <10.9 being deprecated, this test is no longer relevant for those platforms. Given that the CertVerifyProcWeakDigestTest covers the superset of the GTE issue, simply removing this test is sufficient. BUG=590868 R=eroman@chromium.org Committed: https://crrev.com/9ad3f48a16790967f9fc311d83198cc04404b567 Cr-Commit-Position: refs/heads/master@{#378462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -478 lines) Patch
M net/cert/cert_verify_proc_unittest.cc View 1 chunk +0 lines, -123 lines 0 comments Download
M net/data/ssl/certificates/README View 1 chunk +0 lines, -15 lines 0 comments Download
D net/data/ssl/certificates/cybertrust_baltimore_cross_certified_1.pem View 1 chunk +0 lines, -82 lines 0 comments Download
D net/data/ssl/certificates/cybertrust_baltimore_cross_certified_2.pem View 1 chunk +0 lines, -85 lines 0 comments Download
D net/data/ssl/certificates/cybertrust_baltimore_root.pem View 1 chunk +0 lines, -77 lines 0 comments Download
D net/data/ssl/certificates/cybertrust_gte_root.pem View 1 chunk +0 lines, -48 lines 0 comments Download
D net/data/ssl/certificates/cybertrust_omniroot_chain.pem View 1 chunk +0 lines, -48 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ryan Sleevi
4 years, 9 months ago (2016-03-01 01:25:14 UTC) #1
eroman
lgtm
4 years, 9 months ago (2016-03-01 07:54:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751733002/1
4 years, 9 months ago (2016-03-01 15:50:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 17:17:15 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 17:18:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ad3f48a16790967f9fc311d83198cc04404b567
Cr-Commit-Position: refs/heads/master@{#378462}

Powered by Google App Engine
This is Rietveld 408576698