Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1751643002: Fix instrumented libraries sha1 mix-up. (Closed)

Created:
4 years, 9 months ago by eugenis
Modified:
4 years, 9 months ago
Reviewers:
hans, Evgeniy Stepanov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix instrumented libraries sha1 mix-up. Fix an unexplainable confusion in the prebuilt instrumented libraries sha1 identifiers: no-origins-trusty has sha1 that actually belongs to chained-origins trusty, and vice versa. This can never cause a hard failure, but sometimes with-origins build may miss origin information, and, in all cases (we actually see this in clusterfuzz reports) no-origins build prints ORIGIN: invalid(0) at the end of the MSan report. R=hans@chromium.org BUG=590867 NOTRY=true Committed: https://crrev.com/2a28406877d06cc4d7511295067c6be031e70e9d Cr-Commit-Position: refs/heads/master@{#378309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/instrumented_libraries/binaries/msan-chained-origins-trusty.tgz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/instrumented_libraries/binaries/msan-no-origins-trusty.tgz.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
eugenis
4 years, 9 months ago (2016-02-29 22:50:52 UTC) #2
hans
rs-lgtm
4 years, 9 months ago (2016-02-29 22:55:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751643002/1
4 years, 9 months ago (2016-02-29 22:58:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 23:11:42 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 23:13:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a28406877d06cc4d7511295067c6be031e70e9d
Cr-Commit-Position: refs/heads/master@{#378309}

Powered by Google App Engine
This is Rietveld 408576698