Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: test/cctest/test-ast-expression-visitor.cc

Issue 1751613004: Get rid of the different kinds of yield in the AST & full-codegen. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Do an inline call. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/preparser.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-ast-expression-visitor.cc
diff --git a/test/cctest/test-ast-expression-visitor.cc b/test/cctest/test-ast-expression-visitor.cc
index a40f87ccfeb5541fe4c6aa12a0e5b8876dfe3b08..bda1fba3b4e2398020652b940c78d68912a328e6 100644
--- a/test/cctest/test-ast-expression-visitor.cc
+++ b/test/cctest/test-ast-expression-visitor.cc
@@ -378,14 +378,17 @@ TEST(VisitYield) {
CHECK_EXPR(CallRuntime, Bounds::Unbounded());
}
}
- // Explicit yield
+ // Explicit yield (argument wrapped with CreateIterResultObject)
CHECK_EXPR(Yield, Bounds::Unbounded()) {
CHECK_VAR(.generator_object, Bounds::Unbounded());
- CHECK_EXPR(Literal, Bounds::Unbounded());
+ CHECK_EXPR(CallRuntime, Bounds::Unbounded()) {
+ CHECK_EXPR(Literal, Bounds::Unbounded());
+ CHECK_EXPR(Literal, Bounds::Unbounded());
+ }
}
- // Implicit final yield
- CHECK_EXPR(Yield, Bounds::Unbounded()) {
- CHECK_VAR(.generator_object, Bounds::Unbounded());
+ // Argument to implicit final return
+ CHECK_EXPR(CallRuntime, Bounds::Unbounded()) { // CreateIterResultObject
+ CHECK_EXPR(Literal, Bounds::Unbounded());
CHECK_EXPR(Literal, Bounds::Unbounded());
}
// Implicit finally clause
« no previous file with comments | « src/parsing/preparser.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698