Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 1751613004: Get rid of the different kinds of yield in the AST & full-codegen. (Closed)

Created:
4 years, 9 months ago by neis
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Get rid of the different kinds of yield in the AST & full-codegen. Now there is just one kind, corresponding to what was called "initial" before. Replacement for "suspend": when the parser sees a yield in JS code, it will turn it into a Yield node but wrap its argument in an iterator result object. Replacement for "final": the parser simply inserts a return statement instead. R=littledan@chromium.org, mstarzinger@chromium.org BUG= Committed: https://crrev.com/f24dffea4c459cd33e45019b206019908b2788a7 Cr-Commit-Position: refs/heads/master@{#34515}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Port to other archs #

Patch Set 3 : Do an inline call. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+353 lines, -519 lines) Patch
M src/ast/ast.h View 2 chunks +6 lines, -15 lines 0 comments Download
M src/ast/prettyprinter.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 1 chunk +36 lines, -56 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 1 chunk +39 lines, -59 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 1 chunk +38 lines, -58 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 1 chunk +34 lines, -55 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 1 chunk +34 lines, -55 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 1 chunk +37 lines, -57 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +39 lines, -59 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 1 chunk +38 lines, -58 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 1 2 6 chunks +27 lines, -28 lines 0 comments Download
M src/parsing/parser-base.h View 3 chunks +9 lines, -8 lines 0 comments Download
M src/parsing/preparser.h View 3 chunks +5 lines, -3 lines 0 comments Download
M test/cctest/test-ast-expression-visitor.cc View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
neis
4 years, 9 months ago (2016-03-01 14:44:09 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751613004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751613004/20001
4 years, 9 months ago (2016-03-01 15:00:53 UTC) #3
Michael Starzinger
LGTM on the back-ends, didn't look at the parser all too much. https://codereview.chromium.org/1751613004/diff/1/src/parsing/parser.cc File src/parsing/parser.cc ...
4 years, 9 months ago (2016-03-01 15:03:25 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-01 15:24:34 UTC) #6
neis
https://codereview.chromium.org/1751613004/diff/1/src/parsing/parser.cc File src/parsing/parser.cc (right): https://codereview.chromium.org/1751613004/diff/1/src/parsing/parser.cc#newcode505 src/parsing/parser.cc:505: return factory->NewCallRuntime(Runtime::kCreateIterResultObject, args, pos); On 2016/03/01 15:03:25, Michael Starzinger ...
4 years, 9 months ago (2016-03-01 15:26:42 UTC) #7
neis
Dan, can you please have a look at the parser changes?
4 years, 9 months ago (2016-03-04 09:26:10 UTC) #8
Dan Ehrenberg
Parser lgtm
4 years, 9 months ago (2016-03-04 17:21:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751613004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751613004/40001
4 years, 9 months ago (2016-03-06 08:26:41 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-06 09:19:27 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-06 09:20:22 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f24dffea4c459cd33e45019b206019908b2788a7
Cr-Commit-Position: refs/heads/master@{#34515}

Powered by Google App Engine
This is Rietveld 408576698