content/browser/download/download_net_log_parameters.h - Issue 1751603002: [Downloads] Rework how hashes are calculated for download files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_net_log_parameters.h

Issue 1751603002: [Downloads] Rework how hashes are calculated for download files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase on top of https://codereview.chromium.org/1781983002 since that's going in first. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/download/download_manager_impl_unittest.cc ('k') | content/browser/download/download_net_log_parameters.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_net_log_parameters.h

diff --git a/content/browser/download/download_net_log_parameters.h b/content/browser/download/download_net_log_parameters.h

index 2f4b6a006e585bded2bedabe450e2269267b8cd1..b10a345ed337f5ec57d7242fda35d524f6fb633d 100644

--- a/content/browser/download/download_net_log_parameters.h

+++ b/content/browser/download/download_net_log_parameters.h

@@ -50,7 +50,6 @@ scoped_ptr<base::Value> ItemRenamedNetLogCallback(

scoped_ptr<base::Value> ItemInterruptedNetLogCallback(

DownloadInterruptReason reason,

int64_t bytes_so_far,

- const std::string* hash_state,

net::NetLogCaptureMode capture_mode);

// Returns NetLog parameters when a DownloadItem is resumed.

@@ -58,7 +57,6 @@ scoped_ptr<base::Value> ItemResumingNetLogCallback(

bool user_initiated,

DownloadInterruptReason reason,

int64_t bytes_so_far,

- const std::string* hash_state,

net::NetLogCaptureMode capture_mode);

// Returns NetLog parameters when a DownloadItem is completing.

@@ -75,7 +73,6 @@ scoped_ptr<base::Value> ItemFinishedNetLogCallback(

// Returns NetLog parameters when a DownloadItem is canceled.

scoped_ptr<base::Value> ItemCanceledNetLogCallback(

int64_t bytes_so_far,

- const std::string* hash_state,

net::NetLogCaptureMode capture_mode);

// Returns NetLog parameters when a DownloadFile is opened.