chrome/browser/download/download_item_model_unittest.cc - Issue 1751603002: [Downloads] Rework how hashes are calculated for download files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_item_model_unittest.cc

Issue 1751603002: [Downloads] Rework how hashes are calculated for download files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase on top of https://codereview.chromium.org/1781983002 since that's going in first. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_item_model.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_item_model_unittest.cc

diff --git a/chrome/browser/download/download_item_model_unittest.cc b/chrome/browser/download/download_item_model_unittest.cc

index 188e8e0961572f127489fd653f54a878978ff58d..9cb147994274ea91d969f6280111ebdcc4fd1fb4 100644

--- a/chrome/browser/download/download_item_model_unittest.cc

+++ b/chrome/browser/download/download_item_model_unittest.cc

@@ -143,6 +143,8 @@ TEST_F(DownloadItemModelTest, InterruptedStatus) {

"Failed - File truncated"},

{content::DOWNLOAD_INTERRUPT_REASON_FILE_TRANSIENT_ERROR,

"Failed - System busy"},

+ {content::DOWNLOAD_INTERRUPT_REASON_FILE_HASH_MISMATCH,

+ "Failed - Download error"},

{content::DOWNLOAD_INTERRUPT_REASON_NETWORK_FAILED,

"Failed - Network error"},

{content::DOWNLOAD_INTERRUPT_REASON_NETWORK_TIMEOUT,

@@ -215,6 +217,8 @@ TEST_F(DownloadItemModelTest, InterruptTooltip) {

"foo.bar\nFile truncated"},

{content::DOWNLOAD_INTERRUPT_REASON_FILE_TRANSIENT_ERROR,

"foo.bar\nSystem busy"},

+ {content::DOWNLOAD_INTERRUPT_REASON_FILE_HASH_MISMATCH,

+ "foo.bar\nDownload error"},

{content::DOWNLOAD_INTERRUPT_REASON_NETWORK_FAILED,

"foo.bar\nNetwork error"},

{content::DOWNLOAD_INTERRUPT_REASON_NETWORK_TIMEOUT,