content/browser/download/download_item_impl_delegate.cc - Issue 1751603002: [Downloads] Rework how hashes are calculated for download files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_item_impl_delegate.cc

Issue 1751603002: [Downloads] Rework how hashes are calculated for download files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address first round of comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/download_item_impl.cc ('K') | « content/browser/download/download_item_impl_delegate.h ('k') | content/browser/download/download_item_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_item_impl_delegate.cc

diff --git a/content/browser/download/download_item_impl_delegate.cc b/content/browser/download/download_item_impl_delegate.cc

index c1ed48cd1248091464ed46a164c58ca76e3fc4bb..be7432599e18ee1fdbc0dd7aeac3c501b187c368 100644

--- a/content/browser/download/download_item_impl_delegate.cc

+++ b/content/browser/download/download_item_impl_delegate.cc

@@ -56,6 +56,11 @@ bool DownloadItemImplDelegate::ShouldOpenFileBasedOnExtension(

void DownloadItemImplDelegate::CheckForFileRemoval(

DownloadItemImpl* download_item) {}

+std::string DownloadItemImplDelegate::GetApplicationClientIdForFileScanning()

+ const {

+ return std::string();

void DownloadItemImplDelegate::ResumeInterruptedDownload(

scoped_ptr<DownloadUrlParameters> params,

uint32_t id) {}