Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1362)

Unified Diff: content/browser/download/download_file_factory.h

Issue 1751603002: [Downloads] Rework how hashes are calculated for download files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address first round of comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_file_factory.h
diff --git a/content/browser/download/download_file_factory.h b/content/browser/download/download_file_factory.h
index bd083bd76b09c4491c4db6b13901357b667d8871..d29384dde082a18decbae9bdeb9a75770eb03d33 100644
--- a/content/browser/download/download_file_factory.h
+++ b/content/browser/download/download_file_factory.h
@@ -13,6 +13,10 @@
#include "content/common/content_export.h"
#include "url/gurl.h"
+namespace crypto {
+class SecureHash;
+}
+
namespace net {
class BoundNetLog;
}
@@ -30,12 +34,8 @@ class CONTENT_EXPORT DownloadFileFactory {
virtual ~DownloadFileFactory();
virtual DownloadFile* CreateFile(
- const DownloadSaveInfo& save_info,
+ scoped_ptr<DownloadSaveInfo> save_info,
const base::FilePath& default_downloads_directory,
- const GURL& url,
- const GURL& referrer_url,
- bool calculate_hash,
- base::File file,
scoped_ptr<ByteStreamReader> byte_stream,
const net::BoundNetLog& bound_net_log,
base::WeakPtr<DownloadDestinationObserver> observer);

Powered by Google App Engine
This is Rietveld 408576698