chrome/browser/download/download_item_model.cc - Issue 1751603002: [Downloads] Rework how hashes are calculated for download files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_item_model.cc

Issue 1751603002: [Downloads] Rework how hashes are calculated for download files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_history.cc ('K') | « chrome/browser/download/download_history_unittest.cc ('k') | chrome/browser/download/download_item_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_item_model.cc

diff --git a/chrome/browser/download/download_item_model.cc b/chrome/browser/download/download_item_model.cc

index 46694aecc071080a58a14fa941cb273d2aaf1cca..049a3b00bf76c733c96e03e8a75a57224a1dbadd 100644

--- a/chrome/browser/download/download_item_model.cc

+++ b/chrome/browser/download/download_item_model.cc

@@ -179,6 +179,7 @@ base::string16 InterruptReasonStatusMessage(

// fallthrough

case content::DOWNLOAD_INTERRUPT_REASON_SERVER_NO_RANGE:

case content::DOWNLOAD_INTERRUPT_REASON_FILE_FAILED:

+ case content::DOWNLOAD_INTERRUPT_REASON_FILE_HASH_MISMATCH:

asanka 2016/03/04 22:08:06 svaldez: note here and elsewhere that HASH_MISMATC

string_id = IDS_DOWNLOAD_INTERRUPTED_STATUS;

}

@@ -262,6 +263,7 @@ base::string16 InterruptReasonMessage(content::DownloadInterruptReason reason) {

// fallthrough

case content::DOWNLOAD_INTERRUPT_REASON_SERVER_NO_RANGE:

case content::DOWNLOAD_INTERRUPT_REASON_FILE_FAILED:

+ case content::DOWNLOAD_INTERRUPT_REASON_FILE_HASH_MISMATCH:

string_id = IDS_DOWNLOAD_INTERRUPTED_STATUS;

}