mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl - Issue 1751563002: Mojo C++ bindings: support mapping mojo string to WTF::String.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl

Issue 1751563002: Mojo C++ bindings: support mapping mojo string to WTF::String. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/lib/wtf_string_serialization.cc ('K') | « mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl » ('j') | mojo/public/tools/bindings/mojom.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl

index b00b1dad5adcd1fda91a0319aa661e32b653a288..ded54f5f38c7396203feb13a0ca78189536e9c7c 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl

@@ -5,13 +5,13 @@

{%- endfor %}

{%- endmacro %}

-{%- macro declare_callback(method) -%}

+{%- macro declare_callback(method, use_wtf_types) -%}

mojo::Callback<void(

{%- for param in method.response_parameters -%}

{#- TODO(yzshen): Previously |cpp_result_type| is used here incorrectly.

The outcome is we will use mojo::String instead of const mojo::String&.

Preserve the behavior temporarily. #}

-{%- if not param.kind|is_string_kind -%}

+{%- if (not param.kind|is_string_kind) or use_wtf_types -%}

{%- else -%}

mojo::String