Cache csi info before passing it to JS setters.

Cache csi info before passing it to JS setters.

JS setters invalidate the pointers frame, data_source and document_state.

BUG=590455
Committed: https://crrev.com/9d92ff158726601ae5c044d62050614f076eaae4
Cr-Commit-Position: refs/heads/master@{#379047}

[meacer, 2016-02-29 20:03:34]

meacer@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-03-01 14:35:36]

would you be willing to rewrite those bindings using in::Wrappable instead?

v8::Extensions are bad for startup performance and deprecated..

https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/s...
is an example of a previously v8::Extension object

[meacer, 2016-03-01 21:36:32]

On 2016/03/01 14:35:36, jochen wrote:
> would you be willing to rewrite those bindings using in::Wrappable instead?
> 
> v8::Extensions are bad for startup performance and deprecated..
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/s...
> is an example of a previously v8::Extension object

Yes, looking at it now. That said, I think we should land these separately so
that this fix can be clearly merged. I'll send a separate CL for gin:Wrappable.

[jochen (gone - plz use gerrit), 2016-03-02 10:48:31]

https://codereview.chromium.org/1751553002/diff/1/chrome/renderer/loadtimes_e...
File chrome/renderer/loadtimes_extension_bindings.cc (right):

https://codereview.chromium.org/1751553002/diff/1/chrome/renderer/loadtimes_e...
chrome/renderer/loadtimes_extension_bindings.cc:199:
csi->Set(v8::String::NewFromUtf8(isolate, "startE"),
please use the non-deprecated versions:

v8::Local<v8::Context> ctx = isolate->GetCurrentContext();
if (!csi->Set(ctx, v8::String::NewFromUtf8(isolate, "startE",
v8::NewStringType::kNormal).ToLocalChecked()).FromMaybe(false))
  return;

[meacer, 2016-03-02 20:46:36]

https://codereview.chromium.org/1751553002/diff/1/chrome/renderer/loadtimes_e...
File chrome/renderer/loadtimes_extension_bindings.cc (right):

https://codereview.chromium.org/1751553002/diff/1/chrome/renderer/loadtimes_e...
chrome/renderer/loadtimes_extension_bindings.cc:199:
csi->Set(v8::String::NewFromUtf8(isolate, "startE"),
On 2016/03/02 10:48:31, jochen wrote:
> please use the non-deprecated versions:
> 
> v8::Local<v8::Context> ctx = isolate->GetCurrentContext();
> if (!csi->Set(ctx, v8::String::NewFromUtf8(isolate, "startE",
> v8::NewStringType::kNormal).ToLocalChecked()).FromMaybe(false))
>   return;

Done.

[jochen (gone - plz use gerrit), 2016-03-03 06:37:20]

lgtm

[meacer, 2016-03-03 18:26:54]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2016-03-03 18:27:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1751553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1751553002/20001

[commit-bot: I haz the power, 2016-03-03 18:51:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-03 18:53:42]

Description was changed from

==========
Cache csi info before passing it to JS setters.

JS setters invalidate the pointers frame, data_source and document_state.

BUG=590455
==========

to

==========
Cache csi info before passing it to JS setters.

JS setters invalidate the pointers frame, data_source and document_state.

BUG=590455

Committed: https://crrev.com/9d92ff158726601ae5c044d62050614f076eaae4
Cr-Commit-Position: refs/heads/master@{#379047}
==========

[commit-bot: I haz the power, 2016-03-03 18:53:43]

Patchset 2 (id:??) landed as
https://crrev.com/9d92ff158726601ae5c044d62050614f076eaae4
Cr-Commit-Position: refs/heads/master@{#379047}