Dump functions on circular dependency parser error

Dump functions on circular dependency parser error

Help with: https://github.com/dart-lang/sdk/issues/25545

R=turnidge@google.com

Committed: https://github.com/dart-lang/sdk/commit/d08d4d8dba249694d8cd66b071dc515d39071d6f

[Cutch, 2016-02-29 19:33:35]

Description was changed from

==========
Dump functions on circular dependency parser error

BUG=
==========

to

==========
Dump functions on circular dependency parser error

Help with: https://github.com/dart-lang/sdk/issues/25545
==========

[Cutch, 2016-02-29 19:33:35]

johnmccutchan@google.com changed reviewers:
+ turnidge@google.com

[turnidge, 2016-02-29 19:37:56]

lgtm w/ one comment.

https://codereview.chromium.org/1751523003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1751523003/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:2969: result = OS::SCreate(zone, "%s%" Pd ": %s\n", result,
i, fname.ToCString());
There's kind of a quadratic thing going on here, with the copying over and over,
but this code is debug-only, so I'm fine with it.

[Cutch, 2016-02-29 20:32:24]

Description was changed from

==========
Dump functions on circular dependency parser error

Help with: https://github.com/dart-lang/sdk/issues/25545
==========

to

==========
Dump functions on circular dependency parser error

Help with: https://github.com/dart-lang/sdk/issues/25545

R=turnidge@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d08d4d8dba249694d8cd66b071dc515d39071d6f
==========

[Cutch, 2016-02-29 20:32:25]

Committed patchset #2 (id:20001) manually as
d08d4d8dba249694d8cd66b071dc515d39071d6f (presubmit successful).