[Downloads] Move UpdateObservers out of TransitionTo in DownloadItemImpl

content/browser/download/download_item_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_
 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 258 matching lines @@
     // Transitions to:
     //   IN_PROGRESS_INTERNAL  Once a server response is received from a
     //                         resumption.
     //   INTERRUPTED_INTERNAL  If the resumption request fails.
     //   CANCELLED_INTERNAL    On cancel.
     RESUMING_INTERNAL,
 
     MAX_DOWNLOAD_INTERNAL_STATE,
   };
 
+  // Used with TransitionTo() to indicate whether or not to call
+  // UpdateObservers() after the state transition.
+  enum ShouldUpdateObservers {
+    UPDATE_OBSERVERS,
+    DONT_UPDATE_OBSERVERS
+  };
+
   // Normal progression of a download ------------------------------------------
 
   // These are listed in approximately chronological order.  There are also
   // public methods involved in normal download progression; see
   // the implementation ordering in download_item_impl.cc.
 
   // Construction common to all constructors. |active| should be true for new
   // downloads and false for downloads from the history.
   // |download_type| indicates to the net log system what kind of download
   // this is.
@@ skipping 50 matching lines @@
   // object destruction to prevent file destruction. Destroying the file also
   // resets |current_path_|.
   void ReleaseDownloadFile(bool destroy_file);
 
   // Check if a download is ready for completion.  The callback provided
   // may be called at some point in the future if an external entity
   // state has change s.t. this routine should be checked again.
   bool IsDownloadReadyForCompletion(const base::Closure& state_change_notify);
 
   // Call to transition state; all state transitions should go through this.
-  void TransitionTo(DownloadInternalState new_state);
+  // |notify_action| specifies whether or not to call UpdateObservers() after
+  // the state transition.
+  void TransitionTo(DownloadInternalState new_state,
+                    ShouldUpdateObservers notify_action);
 
   // Set the |danger_type_| and invoke obserers if necessary.
   void SetDangerType(DownloadDangerType danger_type);
 
   void SetFullPath(const base::FilePath& new_path);
 
   void AutoResumeIfValid();
 
   void ResumeInterruptedDownload();
 
@@ skipping 167 matching lines @@
   const net::BoundNetLog bound_net_log_;
 
   base::WeakPtrFactory<DownloadItemImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadItemImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_