[Downloads] Move UpdateObservers out of TransitionTo in DownloadItemImpl

content/browser/download/download_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains download browser tests that are known to be runnable
 // in a pure content context.  Over time tests should be migrated here.
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
@@ skipping 1112 matching lines @@
   ConfirmFileStatusForResume(
       download, true, GetSafeBufferChunk() * 3, GetSafeBufferChunk() * 3,
       base::FilePath(FILE_PATH_LITERAL("rangereset")));
 
   static const RecordingDownloadObserver::RecordStruct expected_record[] = {
     // Result of RST
     {DownloadItem::INTERRUPTED, GetSafeBufferChunk()},
     // Starting continuation
     {DownloadItem::IN_PROGRESS, GetSafeBufferChunk()},
     // Server precondition fail.
-    {DownloadItem::INTERRUPTED, GetSafeBufferChunk()},
+    {DownloadItem::INTERRUPTED, 0},
     // Notification of successful restart.
     {DownloadItem::IN_PROGRESS, 0},
     // Completion.
     {DownloadItem::COMPLETE, GetSafeBufferChunk() * 3},
   };
 
   recorder.CompareToExpectedRecord(expected_record, arraysize(expected_record));
 }
 
 // Confirm we don't try to resume if we don't have a verifier.
@@ skipping 76 matching lines @@
   ConfirmFileStatusForResume(
       download, true, GetSafeBufferChunk() * 3, GetSafeBufferChunk() * 3,
       base::FilePath(FILE_PATH_LITERAL("rangereset")));
 
   static const RecordingDownloadObserver::RecordStruct expected_record[] = {
     // Result of RST
     {DownloadItem::INTERRUPTED, GetSafeBufferChunk()},
     // Starting continuation
     {DownloadItem::IN_PROGRESS, GetSafeBufferChunk()},
     // Error because file isn't there.
-    {DownloadItem::INTERRUPTED, GetSafeBufferChunk()},
-    // Restart
+    {DownloadItem::INTERRUPTED, 0},
+    // Restart.
     {DownloadItem::IN_PROGRESS, 0},
     // Completion.
     {DownloadItem::COMPLETE, GetSafeBufferChunk() * 3},
   };
 
   recorder.CompareToExpectedRecord(expected_record, arraysize(expected_record));
 }
 
 IN_PROC_BROWSER_TEST_F(DownloadContentTest, ResumeWithFileInitError) {
   CommandLine::ForCurrentProcess()->AppendSwitch(
@@ skipping 324 matching lines @@
   // Start the second download and wait until it's done. The test server is
   // single threaded. The response to this download request should follow the
   // response to the previous resumption request.
   GURL url2(test_server()->GetURL("rangereset?size=100&rst_limit=0&token=x"));
   DownloadAndWait(shell(), url2, DownloadItem::COMPLETE);
 
   EXPECT_TRUE(EnsureNoPendingDownloads());
 }
 
 }  // namespace content