Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1637)

Unified Diff: content/renderer/pepper/ppb_video_decoder_impl.cc

Issue 1751323002: Allow multiple texture ids per picture buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/ppb_video_decoder_impl.cc
diff --git a/content/renderer/pepper/ppb_video_decoder_impl.cc b/content/renderer/pepper/ppb_video_decoder_impl.cc
index 5c5fcb224a39fe509ce140380deec210274bfaca..bfc9d90f35da037df297107733c7abc99a5ff400 100644
--- a/content/renderer/pepper/ppb_video_decoder_impl.cc
+++ b/content/renderer/pepper/ppb_video_decoder_impl.cc
@@ -183,10 +183,11 @@ void PPB_VideoDecoder_Impl::AssignPictureBuffers(
for (uint32_t i = 0; i < no_of_buffers; i++) {
PP_PictureBuffer_Dev in_buf = buffers[i];
DCHECK_GE(in_buf.id, 0);
+ media::PictureBuffer::TextureIds pepper_buffers;
raymes 2016/03/31 00:09:25 nit: perhaps keep the naming similar to the other
+ pepper_buffers.push_back(in_buf.texture_id);
media::PictureBuffer buffer(
- in_buf.id,
- gfx::Size(in_buf.size.width, in_buf.size.height),
- in_buf.texture_id);
+ in_buf.id, gfx::Size(in_buf.size.width, in_buf.size.height),
+ pepper_buffers);
wrapped_buffers.push_back(buffer);
UMA_HISTOGRAM_COUNTS_10000("Media.PepperVideoDecoderPictureHeight",
in_buf.size.height);
@@ -239,9 +240,11 @@ void PPB_VideoDecoder_Impl::Destroy() {
void PPB_VideoDecoder_Impl::ProvidePictureBuffers(
uint32_t requested_num_of_buffers,
+ uint32_t textures_per_buffer,
const gfx::Size& dimensions,
uint32_t texture_target) {
DCHECK(RenderThreadImpl::current());
+ DCHECK_EQ(1u, textures_per_buffer);
if (!GetPPP())
return;

Powered by Google App Engine
This is Rietveld 408576698