Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1751253002: Address static warning in precompiler compiler configuration. (Closed)

Created:
4 years, 9 months ago by rmacnak
Modified:
4 years, 9 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Address static warning in precompiler compiler configuration. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/6917ae74091ef154890c672269eb8c57dedb5a87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/testing/dart/compiler_configuration.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 9 months ago (2016-03-01 23:49:02 UTC) #2
Florian Schneider
lgtm
4 years, 9 months ago (2016-03-01 23:50:55 UTC) #3
rmacnak
4 years, 9 months ago (2016-03-01 23:51:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6917ae74091ef154890c672269eb8c57dedb5a87 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698