Merge ResourceLoader's ResourceLoaderState and ConnectionState enums

Merge ResourceLoader's ResourceLoaderState and ConnectionState enums

ResourceLoaderState::Initialized maps to ConnectionState{New,Started,
ReceivedResponse,ReceivingData}, ResourceLoaderState::Finishing maps to
ConnectionState{FinishedLoading,Canceled,Failed}. Add a new
ConnectionStateReleased to match ResourceLoaderState::Terminated.

These enums used to be in different classes. The classes were merged a couple
of years ago, but the state machines were left as-is.

BUG=

Committed: https://crrev.com/7ee9c546d4c87bb1cc9eb5a81451005fc80133cd
Cr-Commit-Position: refs/heads/master@{#378924}

[Nate Chapin, 2016-03-02 18:41:47]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-02 18:42:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1751203003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1751203003/1

[commit-bot: I haz the power, 2016-03-02 19:58:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 19:58:24]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-03-02 20:17:29]

japhet@chromium.org changed reviewers:
+ hiroshige@chromium.org, yhirano@chromium.org

[Nate Chapin, 2016-03-02 20:17:29]

Another ResourceLoader cleanup :)

[yhirano, 2016-03-02 20:37:32]

https://codereview.chromium.org/1751203003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/ResourceLoader.cpp (right):

https://codereview.chromium.org/1751203003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/ResourceLoader.cpp:230: if (m_state >=
ConnectionStateFinishedLoading) {
How about having |isFinishing| predicate?

[Nate Chapin, 2016-03-02 23:08:07]

https://codereview.chromium.org/1751203003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/ResourceLoader.cpp (right):

https://codereview.chromium.org/1751203003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/ResourceLoader.cpp:230: if (m_state >=
ConnectionStateFinishedLoading) {
On 2016/03/02 20:37:32, yhirano wrote:
> How about having |isFinishing| predicate?

Done.

[yhirano, 2016-03-02 23:23:23]

lgtm

https://codereview.chromium.org/1751203003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ResourceLoader.cpp (right):

https://codereview.chromium.org/1751203003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ResourceLoader.cpp:220: 
needless empty line?

[Nate Chapin, 2016-03-02 23:24:35]

https://codereview.chromium.org/1751203003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ResourceLoader.cpp (right):

https://codereview.chromium.org/1751203003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ResourceLoader.cpp:220: 
On 2016/03/02 23:23:23, yhirano wrote:
> needless empty line?

Oops, will remove before landing.

[Nate Chapin, 2016-03-03 00:32:37]

The CQ bit was checked by japhet@chromium.org

[Nate Chapin, 2016-03-03 00:32:38]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/1751203003/#ps40001
(title: "Remove spurious newline")

[commit-bot: I haz the power, 2016-03-03 00:33:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1751203003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1751203003/40001

[commit-bot: I haz the power, 2016-03-03 02:36:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-03 02:37:31]

Description was changed from

==========
Merge ResourceLoader's ResourceLoaderState and ConnectionState enums

ResourceLoaderState::Initialized maps to ConnectionState{New,Started,
ReceivedResponse,ReceivingData}, ResourceLoaderState::Finishing maps to
ConnectionState{FinishedLoading,Canceled,Failed}. Add a new
ConnectionStateReleased to match ResourceLoaderState::Terminated.

These enums used to be in different classes. The classes were merged a couple
of years ago, but the state machines were left as-is.

BUG=
==========

to

==========
Merge ResourceLoader's ResourceLoaderState and ConnectionState enums

ResourceLoaderState::Initialized maps to ConnectionState{New,Started,
ReceivedResponse,ReceivingData}, ResourceLoaderState::Finishing maps to
ConnectionState{FinishedLoading,Canceled,Failed}. Add a new
ConnectionStateReleased to match ResourceLoaderState::Terminated.

These enums used to be in different classes. The classes were merged a couple
of years ago, but the state machines were left as-is.

BUG=

Committed: https://crrev.com/7ee9c546d4c87bb1cc9eb5a81451005fc80133cd
Cr-Commit-Position: refs/heads/master@{#378924}
==========

[commit-bot: I haz the power, 2016-03-03 02:37:32]

Patchset 3 (id:??) landed as
https://crrev.com/7ee9c546d4c87bb1cc9eb5a81451005fc80133cd
Cr-Commit-Position: refs/heads/master@{#378924}