Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1751153002: Adjust new tab button path to get crisp line along top edge (Mac). (Closed)

Created:
4 years, 9 months ago by shrike
Modified:
4 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust new tab button path to get crisp line along top edge (Mac). BUG=590974 Committed: https://crrev.com/339bd5d94f7ce32a1d6f6d03f1d1e703b447d0a0 Cr-Commit-Position: refs/heads/master@{#378561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/new_tab_button.mm View 6 chunks +24 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
shrike
This is simple change, so should not require much work or time to review. PTAL
4 years, 9 months ago (2016-03-01 20:31:11 UTC) #3
Avi (use Gerrit)
lgtm 👍
4 years, 9 months ago (2016-03-01 20:35:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751153002/1
4 years, 9 months ago (2016-03-01 20:37:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 21:23:32 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 21:24:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/339bd5d94f7ce32a1d6f6d03f1d1e703b447d0a0
Cr-Commit-Position: refs/heads/master@{#378561}

Powered by Google App Engine
This is Rietveld 408576698