Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1751093002: Replace FX_LPCRECT typedef with underlying types (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace FX_LPCRECT typedef with underlying types Helps with transparency. Also remove default args and use override consistently in the affected methods. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/50dfc4a7068e8e08105f7b9a3945136e7246e677

Patch Set 1 #

Patch Set 2 : Default args, override. #

Total comments: 1

Patch Set 3 : Remove one more default value. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -68 lines) Patch
M core/include/fxcrt/fx_coordinates.h View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/src/fee/include/ifde_txtedtpage.h View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtpage.h View 1 2 chunks +40 lines, -37 lines 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtpage.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M xfa/src/fgas/include/fx_rbk.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/include/fx_tbk.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/src/font/fx_gefont.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_editimp.cpp View 1 3 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Dan, please review.
4 years, 9 months ago (2016-03-01 18:42:19 UTC) #3
dsinclair
lgtm https://codereview.chromium.org/1751093002/diff/20001/xfa/src/fee/include/ifde_txtedtpage.h File xfa/src/fee/include/ifde_txtedtpage.h (right): https://codereview.chromium.org/1751093002/diff/20001/xfa/src/fee/include/ifde_txtedtpage.h#newcode35 xfa/src/fee/include/ifde_txtedtpage.h:35: CFX_RectF* pBBox = NULL) const = 0; Can ...
4 years, 9 months ago (2016-03-01 18:57:52 UTC) #4
Tom Sepez
yes.
4 years, 9 months ago (2016-03-01 19:33:45 UTC) #5
Tom Sepez
4 years, 9 months ago (2016-03-01 19:34:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
50dfc4a7068e8e08105f7b9a3945136e7246e677 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698