Speed up the LookupIterator

Speed up the LookupIterator

This introduces a new instance type and reorders the JSObject types so any type requiring special LookupIterator support can be identified with a single range check.

In addition, it restructures the Next for better performance, avoiding unnecessary calls.

BUG=

Committed: https://crrev.com/2608ecc7157a9d6d482709fc197b2fc0317d9d09
Cr-Commit-Position: refs/heads/master@{#34429}

[Toon Verwaest, 2016-03-01 17:37:26]

verwaest@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Toon Verwaest, 2016-03-01 17:37:27]

ptal
suggestions for better instance type names welcome :)

[Jakob Kummerow, 2016-03-02 12:48:37]

lgtm

https://codereview.chromium.org/1751043002/diff/60001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1751043002/diff/60001/src/objects.h#newcode708
src/objects.h:708: JS_SPECIAL_API_OBJECT_TYPE,  // LAST_SPECIAL_RECEIVER_TYPE
Maybe include a comment right here? Roughly: "Like JS_OBJECT_TYPE, but requires
access checks and/or has interceptors."

[Toon Verwaest, 2016-03-02 12:52:26]

Addressed

https://codereview.chromium.org/1751043002/diff/60001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1751043002/diff/60001/src/objects.h#newcode708
src/objects.h:708: JS_SPECIAL_API_OBJECT_TYPE,  // LAST_SPECIAL_RECEIVER_TYPE
On 2016/03/02 12:48:36, Jakob wrote:
> Maybe include a comment right here? Roughly: "Like JS_OBJECT_TYPE, but
requires
> access checks and/or has interceptors."

Done.

[Toon Verwaest, 2016-03-02 12:52:40]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-03-02 12:52:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1751043002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-03-02 12:52:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1751043002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1751043002/80001

[commit-bot: I haz the power, 2016-03-02 13:07:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 13:07:36]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11771)

[jochen (gone - plz use gerrit), 2016-03-02 13:22:17]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-03-02 13:22:17]

lgtm

[Toon Verwaest, 2016-03-02 13:27:18]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-03-02 13:27:19]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1751043002/#ps100001
(title: "Fix proxy + private symbols")

[commit-bot: I haz the power, 2016-03-02 13:27:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1751043002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1751043002/100001

[commit-bot: I haz the power, 2016-03-02 13:48:56]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-02 13:49:19]

Description was changed from

==========
Speed up the LookupIterator

This introduces a new instance type and reorders the JSObject types so any type
requiring special LookupIterator support can be identified with a single range
check.

In addition, it restructures the Next for better performance, avoiding
unnecessary calls.

BUG=
==========

to

==========
Speed up the LookupIterator

This introduces a new instance type and reorders the JSObject types so any type
requiring special LookupIterator support can be identified with a single range
check.

In addition, it restructures the Next for better performance, avoiding
unnecessary calls.

BUG=

Committed: https://crrev.com/2608ecc7157a9d6d482709fc197b2fc0317d9d09
Cr-Commit-Position: refs/heads/master@{#34429}
==========

[commit-bot: I haz the power, 2016-03-02 13:49:20]

Patchset 6 (id:??) landed as
https://crrev.com/2608ecc7157a9d6d482709fc197b2fc0317d9d09
Cr-Commit-Position: refs/heads/master@{#34429}

[Michael Achenbach, 2016-03-02 18:42:21]

This breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

Would love to just revert, but it seems some stuff landed already on top of
this...

[Michael Achenbach, 2016-03-02 18:43:12]

machenbach@chromium.org changed reviewers:
+ hablich@chromium.org, machenbach@chromium.org

[Michael Achenbach, 2016-03-02 18:43:13]

FYI hablich, the layout test breakage blocks the roll

[Michael Achenbach, 2016-03-02 18:44:03]

On 2016/03/02 18:43:13, Michael Achenbach wrote:
> FYI hablich, the layout test breakage blocks the roll

Looks like some tests are timing out.