Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1751033002: Remove _XFA_EMB (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove _XFA_EMB The _XFA_EMB flag is never defined, remove conditionals. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c441552aa9776b9fbdecf3e17d20ba096512f388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -77 lines) Patch
M xfa/src/fxfa/src/app/xfa_ffchoicelist.cpp View 1 chunk +5 lines, -14 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fffield.cpp View 1 chunk +15 lines, -25 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftextedit.cpp View 1 chunk +4 lines, -14 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidget.cpp View 1 chunk +5 lines, -8 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fwladapter.cpp View 2 chunks +3 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dsinclair
PTAL.
4 years, 9 months ago (2016-03-01 15:28:05 UTC) #3
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-01 17:10:10 UTC) #4
dsinclair
4 years, 9 months ago (2016-03-01 17:46:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c441552aa9776b9fbdecf3e17d20ba096512f388 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698