Issue 1751018: Remove unused local variables now that subclasses don't need to track their o...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1751018: Remove unused local variables now that subclasses don't need to track their o... (Closed)

Created:
10 years, 8 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Mohamed Mansour

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove unused local variables now that subclasses don't need to track their own accessibile name. (In other words, I forgot to do this in r43558.) BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45512

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -55 lines)			Patch
M	chrome/browser/chromeos/frame/normal_browser_frame_view.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/views/accessible_toolbar_view.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/views/bookmark_bar_view.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/views/extensions/extension_shelf.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/views/frame/opaque_browser_frame_view.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/views/infobars/infobar_container.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/views/infobars/infobars.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/views/tab_contents/tab_contents_container.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_strip.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	views/controls/button/button.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	views/controls/combobox/combobox.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	views/controls/progress_bar.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	views/controls/resize_gripper.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	views/controls/single_split_view.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	views/controls/textfield/textfield.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	views/widget/root_view.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	views/window/non_client_view.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, good catch.

Expand Messages | Collapse Messages