Fix recipe module git to use package_resouce.

Fix recipe module git to use package_resouce.

TBR=phajdan.jr@chromium.org,martiniss@chromium.org
BUG=590806
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299027

[tandrii(chromium), 2016-03-01 14:13:46]

Description was changed from

==========
Fix recipe module git to use package_resouce.

R=phajdan.jr@chromium.org,martiniss@chromium.org
BUG=590806
==========

to

==========
Fix recipe module git to use package_resouce.

TBR=phajdan.jr@chromium.org,martiniss@chromium.org
BUG=590806
==========

[tandrii(chromium), 2016-03-01 14:13:51]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-03-01 14:13:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1751003002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1751003002/1

[tandrii(chromium), 2016-03-01 14:15:44]

The CQ bit was unchecked by tandrii@chromium.org

[Michael Achenbach, 2016-03-01 14:20:36]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-03-01 14:20:37]

lgtm

https://codereview.chromium.org/1751003002/diff/1/recipe_modules/git/api.py
File recipe_modules/git/api.py (right):

https://codereview.chromium.org/1751003002/diff/1/recipe_modules/git/api.py#n...
recipe_modules/git/api.py:40: def ensure_git_tooling(self):
Maybe make the name windows-specific or make the method private.

[Paweł Hajdan Jr., 2016-03-01 14:31:42]

LGTM

[tandrii(chromium), 2016-03-01 14:42:14]

On 2016/03/01 14:20:37, Michael Achenbach wrote:
> lgtm
> 
> https://codereview.chromium.org/1751003002/diff/1/recipe_modules/git/api.py
> File recipe_modules/git/api.py (right):
> 
>
https://codereview.chromium.org/1751003002/diff/1/recipe_modules/git/api.py#n...
> recipe_modules/git/api.py:40: def ensure_git_tooling(self):
> Maybe make the name windows-specific or make the method private.

Good idea, and that also helped me find & fix a bug.

[tandrii(chromium), 2016-03-01 14:42:28]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2016-03-01 14:42:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/1751003002/#ps20001
(title: "review + bugfix")

[commit-bot: I haz the power, 2016-03-01 14:42:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1751003002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1751003002/20001

[tandrii(chromium), 2016-03-01 14:45:08]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2016-03-01 14:45:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/1751003002/#ps40001
(title: "fix expectations")

[commit-bot: I haz the power, 2016-03-01 14:45:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1751003002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1751003002/40001

[commit-bot: I haz the power, 2016-03-01 14:49:47]

Description was changed from

==========
Fix recipe module git to use package_resouce.

TBR=phajdan.jr@chromium.org,martiniss@chromium.org
BUG=590806
==========

to

==========
Fix recipe module git to use package_resouce.

TBR=phajdan.jr@chromium.org,martiniss@chromium.org
BUG=590806

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299027
==========

[commit-bot: I haz the power, 2016-03-01 14:49:48]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299027