Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1750993002: Revert of Disable page navigation GC (Closed)

Created:
4 years, 9 months ago by keishi
Modified:
4 years, 9 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
chromium-reviews, tyoshino+watch_chromium.org, oilpan-reviews, Mads Ager (chromium), loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, kinuko+watch, Nate Chapin, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable page navigation GC (patchset #5 id:80001 of https://codereview.chromium.org/1698703002/ ) Reason for revert: Caused some unintended perf regressions. Original issue's description: > Disable page navigation GC > > Page navigation GC is firing too much in some circumstances. This CL disables it to observe impact. > > BUG=588029 > > Committed: https://crrev.com/6ee2be06467613d8770c041a30e123cc23d8e752 > Cr-Commit-Position: refs/heads/master@{#376385} TBR=oilpan-reviews@chromium.org,haraken@chromium.org,sigbjornf@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=588029 Committed: https://crrev.com/7e7bfd6d94de0fbdef0744d98d73f8d2410f1821 Cr-Commit-Position: refs/heads/master@{#378445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (1 generated)
keishi
Created Revert of Disable page navigation GC
4 years, 9 months ago (2016-03-01 13:50:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750993002/1
4 years, 9 months ago (2016-03-01 13:50:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750993002/1
4 years, 9 months ago (2016-03-01 14:01:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750993002/1
4 years, 9 months ago (2016-03-01 14:31:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750993002/1
4 years, 9 months ago (2016-03-01 15:01:37 UTC) #5
sof
lgtm
4 years, 9 months ago (2016-03-01 15:06:27 UTC) #6
haraken
LGTM
4 years, 9 months ago (2016-03-01 15:28:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750993002/1
4 years, 9 months ago (2016-03-01 15:31:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750993002/1
4 years, 9 months ago (2016-03-01 16:01:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 16:16:33 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7e7bfd6d94de0fbdef0744d98d73f8d2410f1821 Cr-Commit-Position: refs/heads/master@{#378445}
4 years, 9 months ago (2016-03-01 16:18:57 UTC) #12
haraken
4 years, 9 months ago (2016-03-03 02:08:20 UTC) #13
Message was sent while issue was closed.
I'd prioritize fixing the page navigation GCs rather than per-thread heaps.

Powered by Google App Engine
This is Rietveld 408576698