Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1750983002: Remove unused HashSet<>::isValidValue(). (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
tkent, haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused HashSet<>::isValidValue(). R= BUG= Committed: https://crrev.com/bdde21ef23cd45045f294e9ad22d51f5ffd1e895 Cr-Commit-Position: refs/heads/master@{#378435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M third_party/WebKit/Source/wtf/HashSet.h View 2 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 9 months ago (2016-03-01 13:00:24 UTC) #2
haraken
LGTM
4 years, 9 months ago (2016-03-01 15:30:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750983002/1
4 years, 9 months ago (2016-03-01 15:32:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 15:39:33 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 15:41:33 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bdde21ef23cd45045f294e9ad22d51f5ffd1e895
Cr-Commit-Position: refs/heads/master@{#378435}

Powered by Google App Engine
This is Rietveld 408576698